[jira] [Resolved] (KAFKA-1259) Producer close function no longer block until all messages be sent

["Jay Kreps (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jay Kreps resolved KAFKA-1259.
------------------------------

    Resolution: Fixed

The logic we had was to block until all requests were sent but not until all responses were received (which is wrong). Not sure why that test passed before, but I confirmed that this fixes it.

> Producer close function no longer block until all messages be sent
> ------------------------------------------------------------------
>
>                 Key: KAFKA-1259
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1259
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: producer 
>            Reporter: Guozhang Wang
>            Assignee: Jay Kreps
>         Attachments: KAFKA-1259.patch
>
>
> The testClose currently breaks since
> assertTrue("The last message should be acked before producer is shutdown", response0.isDone)
> fails, it was fine before some commits on 2/10.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)