You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/18 23:25:31 UTC
[GitHub] [tvm] mehrdadh opened a new pull request #8283: [microTVM] Refactor uTVM to microTVM
mehrdadh opened a new pull request #8283:
URL: https://github.com/apache/tvm/pull/8283
This PR:
- Rename all uTVM files and definitions to microTVM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-865080477
@leandron @Mousius thanks for pointing out those files. I fixed all of them.
We still have couple of `µTVM` and `utvm` in `NEWS.md` which are mentioning some PRs. I haven't changed those. Here is a list of them:
* µtvm debug improvements #5648
* µTVM CRT modifications for on-device RPC server #5921
* AutoTVM + uTVM for Cortex-M7 (#5417)
* uTVM support for ARM STM32F746XX boards (#4274)
* [BUILD] Disable utvm standalone runtime by default (#4240)
We could also refactor these if someone with contributor access could help in renaming these PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
Mousius commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-864895796
This is a great improvement @mehrdadh, I agree `microTVM` is the most correct as I had similar feelings towards the awkwardness of `µTVM` -> `uTVM` (and `µ` broke one of my scripts :crying_cat_face:). Thanks for proposing this :smile_cat:
One small thing that follows on from @leandron's comment is that there are also some `µ`s hiding in `NEWS.md` and `CONTRIBUTORS.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
Mousius commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-864895796
This is a great improvement @mehrdadh, I agree `microTVM` is the most correct as I had similar feelings towards the awkwardness of `µTVM` -> `uTVM` (and `µ` broke one of my scripts :crying_cat_face:). Thanks for proposing this :smile_cat:
One small thing that follows on from @leandron's comment is that there are also some `µ`s hiding in `NEWS.md` and `CONTRIBUTORS.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #8283:
URL: https://github.com/apache/tvm/pull/8283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero edited a comment on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
gromero edited a comment on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-864320598
Hi @mehrdadh Since I joined the project I was inclined to use (and tried to stick with) the form "uTVM". I have no strong feelings other than really sticking with only one form, hence I think that PR makes sense indeed (ppl might even write mTVM sometimes, which doesn't look good at all). I'm just wondering if I missed any discussion or thread about favoring microTVM. Either way I think using microTVM is the right choice, because uTVM is often written also using the _mu_ symbol (Greek), which is confusing sometimes and might be difficult to type on some consoles. On Linux I also prefer typing "micro" instead of CTRL-Shift-u-b-5 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-864480692
> The main reason as you mentioned is that "uTVM" is kinda confusing, specially for the people who are using it for the first time. And it's not really straightforward to write. It would be great if we unify it and make sure everyone is using the same brand.
Yeah, thanks for proposing that change.
> We had some internal conversation, but we didn't have a community discussion about choosing a name, I guess mostly because I thought it's not a major change. However, we could post an RFC and ask for people's vote.
I asked just out of curiosity. I thought of a change like that just after I joined the project so I was wondering if I missed anything recently in the open so I could check it out curiosity. I really don't think it's necessary a RFC for that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-864331860
@gromero thanks for the feedback!
The main reason as you mentioned is that "uTVM" is kinda confusing, specially for the people who are using it for the first time. And it's not really straightforward to write. It would be great if we unify it and make sure everyone is using the same brand.
We had some internal conversation, but we didn't have a community discussion about choosing a name, I guess mostly because I thought it's not a major change. However, we could post an RFC and ask for people's vote.
We could also CC people here and see if anyone has any suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh edited a comment on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
mehrdadh edited a comment on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-865088120
cc @hogepodge
It would be great to also reflect this PR in TVM doc. I'll be happy to do it if you could point me to where the doc lives.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-864320598
Hi @mehrdadh Since I joined the project I was inclined to use (and tried to stick with) the form "uTVM". I have no strong feelings other than really sticking with only one form, hence I think that PR makes sense indeed (ppl might even write mTVM sometimes, which doesn't look good at all). I'm just wondering if I missed any discussion or thread about favoring microTVM. Either way I think using microTVM is the right choice, because uTVM is often written also using the _mu_ symbol (Greek), which is confusing sometimes and might be difficult to write on some consoles. On Linux I also prefer typing "micro" instead of CTRL-Shift-u-b-5 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-864317073
cc @areusch @gromero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-865080477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh edited a comment on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
mehrdadh edited a comment on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-865088120
cc @hogepodge
It would be great to also reflect this PR in TVM doc. I'll be happy to do it if you could point me to where the doc lives.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #8283:
URL: https://github.com/apache/tvm/pull/8283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-864332050
CC @leandron @manupa-arm @guberti @Mousius @giuseros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #8283: [microTVM] Refactor uTVM to microTVM
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8283:
URL: https://github.com/apache/tvm/pull/8283#issuecomment-865088120
cc @hogepodge
It would be great to also reflect this PR in TVM doc. I'll be happy to do it if you could point me to where the do lives.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org