You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2013/09/19 08:11:32 UTC

[jclouds-chef] JCLOUDS-286: Use by default the Omnibus installer (#26)

Allow to use the Omnibus installer script added in https://github.com/jclouds/jclouds/pull/151
You can merge this Pull Request by running:

  git pull https://github.com/nacx/jclouds-chef 286-chef-omnibus

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-chef/pull/26

-- Commit Summary --

  * JCLOUDS-286: Use by default the Omnibus installer

-- File Changes --

    M core/src/main/java/org/jclouds/chef/ChefApiMetadata.java (4)
    M core/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java (28)
    M core/src/main/java/org/jclouds/chef/config/ChefProperties.java (15)
    A core/src/main/java/org/jclouds/chef/config/InstallChef.java (39)
    M core/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java (10)
    M core/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java (93)

-- Patch Links --

https://github.com/jclouds/jclouds-chef/pull/26.patch
https://github.com/jclouds/jclouds-chef/pull/26.diff

Re: [jclouds-chef] JCLOUDS-286: Use by default the Omnibus installer (#26)

Posted by Andrew Phillips <no...@github.com>.

Looks good to me in a very quick review. I guess setting this new parameter to default to `true` and thus change the default behaviour for users was intentional (rather than e.g. starting off with default `false` and telling users the default will change to `true` in a future version)?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/26#issuecomment-27155933

Re: [jclouds-chef] JCLOUDS-286: Use by default the Omnibus installer (#26)

Posted by Ignasi Barrera <no...@github.com>.

Yes, that was intentional.

This just changes the way Ruby and Chef are installed. The most common use case is to deploy VMs that don't have the appropriate Ruby version and the Chef gem installed. Installing Ruby and Rubygems is different in each OS, and available versions may differ too. This motivated the properties to customize how all this was installed.

The Omnibus packages install an entire Ruby distribution with Chef already there in an isolated directory, so there is no need to deal with gem version conflicts and with different OS packages/versions; the Omnibus installer does that dirty job. Users will end up with a self contained Chef and Ruby that does not modify the system Ruby, if any.

Installing Chef with Omnibus is more clean, simple, removes some failure points, and takes care of the OS specific stuff for us, so I decided to make it the default option. It is also the way Opscode recommends to install Chef. Users with an already existing Ruby can also use the "advanced" way to install the Chef gems here, if they prefer.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/26#issuecomment-27167733

Re: [jclouds-chef] JCLOUDS-286: Use by default the Omnibus installer (#26)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-chef-pull-requests #71](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/71/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/26#issuecomment-24776201

Re: [jclouds-chef] JCLOUDS-286: Use by default the Omnibus installer (#26)

Posted by Andrew Phillips <no...@github.com>.

> Yes, that was intentional.

OK, thanks for explaining!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/26#issuecomment-27171271

Re: [jclouds-chef] JCLOUDS-286: Use by default the Omnibus installer (#26)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-chef-pull-requests #61](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/61/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/26#issuecomment-24719242

Re: [jclouds-chef] JCLOUDS-286: Use by default the Omnibus installer (#26)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-chef-pull-requests #70](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/70/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/26#issuecomment-24740404

Re: [jclouds-chef] JCLOUDS-286: Use by default the Omnibus installer (#26)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-chef #423](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/423/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/26#issuecomment-24776114