[GitHub] srowen commented on a change in pull request #23559: [SPARK-26630][SQL] Fix ClassCastException in TableReader while creating HadoopRDD

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23559: [SPARK-26630][SQL] Fix ClassCastException in TableReader while creating HadoopRDD
URL: https://github.com/apache/spark/pull/23559#discussion_r249288834
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
 ##########
 @@ -289,15 +287,28 @@ class HadoopTableReader(
   }
 
   /**
-   * Creates a HadoopRDD based on the broadcasted HiveConf and other job properties that will be
+   * The entry of creating a RDD.
+   */
+  private def createHadoopRDD(
+      inputClassName: String, localTableDesc: TableDesc, inputPathStr: String): RDD[Writable] = {
+    if (classOf[org.apache.hadoop.mapreduce.InputFormat[_, _]]
 
 Review comment:
   I don't know if you need a method and this type of check.. just pattern-match on the result of `hiveTable.getInputFormatClass`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org