[shardingsphere] branch master updated: [Issue #20376]-Improved coverage of DropTableStatementHandler (#20801)

[du...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 302c2675977 [Issue #20376]-Improved coverage of DropTableStatementHandler (#20801)
302c2675977 is described below

commit 302c2675977ad3346d6a431914f10f5e3b570db4
Author: Abhinav Koppula <ab...@gmail.com>
AuthorDate: Tue Sep 6 05:29:06 2022 +0530

    [Issue #20376]-Improved coverage of DropTableStatementHandler (#20801)
    
    * [Issue #20376]-Improved coverage of DropTableStatementHandler
    
    * [ReviewComment]-Fixed formatting
---
 .../handler/ddl/DropTableStatementHandlerTest.java | 35 ++++++++++++++--------
 1 file changed, 23 insertions(+), 12 deletions(-)

diff --git a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropTableStatementHandlerTest.java b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropTableStatementHandlerTest.java
index e62e5f03bfa..ef6f159a5fa 100644
--- a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropTableStatementHandlerTest.java
+++ b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropTableStatementHandlerTest.java
@@ -18,6 +18,7 @@
 package org.apache.shardingsphere.sql.parser.sql.dialect.handler.ddl;
 
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.ddl.MySQLDropTableStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.opengauss.ddl.OpenGaussDropTableStatement;
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleDropTableStatement;
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropTableStatement;
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.sql92.ddl.SQL92DropTableStatement;
@@ -30,42 +31,52 @@ import static org.junit.Assert.assertTrue;
 public final class DropTableStatementHandlerTest {
     
     @Test
-    public void assertContainsIfExistsForMySQL() {
+    public void assertIfExistsForMySQL() {
         assertTrue(DropTableStatementHandler.ifExists(new MySQLDropTableStatement(true)));
+        assertFalse(DropTableStatementHandler.ifExists(new MySQLDropTableStatement(false)));
     }
     
     @Test
-    public void assertContainsIfExistsForPostgreSQL() {
+    public void assertIfExistsForPostgreSQL() {
         assertTrue(DropTableStatementHandler.ifExists(new PostgreSQLDropTableStatement(true, false)));
+        assertFalse(DropTableStatementHandler.ifExists(new PostgreSQLDropTableStatement(false, false)));
     }
     
     @Test
-    public void assertContainsIfExistsForSQLServer() {
+    public void assertIfExistsForSQLServer() {
         assertTrue(DropTableStatementHandler.ifExists(new SQLServerDropTableStatement(true)));
+        assertFalse(DropTableStatementHandler.ifExists(new SQLServerDropTableStatement(false)));
     }
     
     @Test
-    public void assertNotContainsIfExistsForMySQL() {
-        assertFalse(DropTableStatementHandler.ifExists(new MySQLDropTableStatement(false)));
+    public void assertIfExistsForGauss() {
+        assertFalse(DropTableStatementHandler.ifExists(new OpenGaussDropTableStatement(false, true)));
+        assertTrue(DropTableStatementHandler.ifExists(new OpenGaussDropTableStatement(true, true)));
     }
     
     @Test
-    public void assertNotContainsIfExistsForOracle() {
+    public void assertNotExistsForOtherDatabases() {
         assertFalse(DropTableStatementHandler.ifExists(new OracleDropTableStatement()));
+        assertFalse(DropTableStatementHandler.ifExists(new SQL92DropTableStatement()));
     }
     
     @Test
-    public void assertNotContainsIfExistsForPostgreSQL() {
-        assertFalse(DropTableStatementHandler.ifExists(new PostgreSQLDropTableStatement(false, false)));
+    public void assertContainsCascadeForPostgres() {
+        assertFalse(DropTableStatementHandler.containsCascade(new PostgreSQLDropTableStatement(false, false)));
+        assertTrue(DropTableStatementHandler.containsCascade(new PostgreSQLDropTableStatement(true, true)));
     }
     
     @Test
-    public void assertNotContainsIfExistsForSQL92() {
-        assertFalse(DropTableStatementHandler.ifExists(new SQL92DropTableStatement()));
+    public void assertContainsCascadeForGauss() {
+        assertFalse(DropTableStatementHandler.containsCascade(new OpenGaussDropTableStatement(false, false)));
+        assertTrue(DropTableStatementHandler.containsCascade(new OpenGaussDropTableStatement(true, true)));
     }
     
     @Test
-    public void assertNotContainsIfExistsForSQLServer() {
-        assertFalse(DropTableStatementHandler.ifExists(new SQLServerDropTableStatement(false)));
+    public void assertNotContainsCascadeForOtherDatabases() {
+        assertFalse(DropTableStatementHandler.containsCascade(new MySQLDropTableStatement(false)));
+        assertFalse(DropTableStatementHandler.containsCascade(new OracleDropTableStatement()));
+        assertFalse(DropTableStatementHandler.containsCascade(new SQL92DropTableStatement()));
+        assertFalse(DropTableStatementHandler.containsCascade(new SQLServerDropTableStatement(false)));
     }
 }