[GitHub] [couchdb-glazier] lostnet commented on a diff in pull request #15: Simplified build chain and updated build scripts to VS 2022

[GitBox <gi...@apache.org>]

lostnet commented on code in PR #15:
URL: https://github.com/apache/couchdb-glazier/pull/15#discussion_r852908118


##########
bin/install_dependencies.ps1:
##########
@@ -10,36 +10,49 @@
 # License for the specific language governing permissions and limitations under
 # the License.
 
-# requires English language pack installed
-choco install visualstudio2017buildtools "--passive --locale en-US"
-choco install visualstudio2017-workload-vctools --package-parameters "--includeRecommended --add Microsoft.VisualStudio.Component.VC.ATLMFC"
-choco install visualstudio2017-workload-nativedesktop
-choco install windows-sdk-10.1 nodejs-lts wget nasm cyg-get wixtoolset python3 make nssm gpg4win checksum archiver dependencywalker unzip
-choco install nsis --version=2.51
+# Sourcing variable definitions
+. ${PSScriptRoot}\variables.ps1
+
+# Exclude c:\relax from MS defender to speed up things
+Add-MpPreference -ExclusionPath "C:\relax"
+
+# Install build tools - requires English language pack installed
+choco install visualstudio2022buildtools "--passive --locale en-US"
+choco install visualstudio2022-workload-vctools --package-parameters "--add Microsoft.VisualStudio.Component.VC.ATL --add Microsoft.VisualStudio.Component.VC.Redist.MSM --add Microsoft.Net.Component.4.8.TargetingPack"
+choco install nodejs-lts wixtoolset make nssm python3 vswhere gnuwin32-coreutils.portable

Review Comment:
   One other improvement I was thinking of to help when we are troubleshooting or trying to reproduce past builds, was adding info on how to dump version info of what packages have been installed by choco, vcpkg, etc, and a suggested place to store this for the convenience binaries.



##########
moz/sm-opt:
##########
@@ -0,0 +1,24 @@
+# Build only the JS shell
+ac_add_options --enable-application=js
+
+# Enable optimization for speed
+ac_add_options --enable-optimize
+
+# Disable debug checks to better match a release build of Firefox.
+ac_add_options --disable-debug
+
+ac_add_options --disable-ctypes
+ac_add_options --disable-jit
+ac_add_options --disable-jemalloc
+ac_add_options --enable-hardening
+ac_add_options --with-intl-api
+ac_add_options --build-backends=RecursiveMake
+#ac_add_options --with-system-icu

Review Comment:
   I don't remember if we were going to eventually switch back to system icu, but I think we decided it was ok not to. It does raise the question of whether we need to add a test for the couchdb query server to make sure the icu related locale functions are working.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org