You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gengliangwang (via GitHub)" <gi...@apache.org> on 2024/03/29 17:11:32 UTC
Re: [PR] [SPARK-47637][SQL] Use errorCapturingIdentifier in more places [spark]
gengliangwang commented on code in PR #45764:
URL: https://github.com/apache/spark/pull/45764#discussion_r1544704120
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -76,7 +76,7 @@ statement
| ctes? dmlStatementNoWith #dmlStatement
| USE identifierReference #use
| USE namespace identifierReference #useNamespace
- | SET CATALOG (identifier | stringLit) #setCatalog
+ | SET CATALOG (errorCapturingIdentifier | stringLit) #setCatalog
Review Comment:
Do we consider extending:
```
IDENTIFIER
: (UNICODE_LETTER | DIGIT | '_')+
| UNICODE_LETTER+ '://' (UNICODE_LETTER | DIGIT | '_' | '/' | '-' | '.' | '?' | '=' | '&' | '#' | '%')+
```
to
```
IDENTIFIER
: (UNICODE_LETTER | DIGIT | '_' | '-')+
| UNICODE_LETTER+ '://' (UNICODE_LETTER | DIGIT | '_' | '/' | '-' | '.' | '?' | '=' | '&' | '#' | '%')+
```
so that we can remove all errorCapturingIdentifier for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org