You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/12/24 19:44:49 UTC

[GitHub] [trafficserver] wkaras commented on a diff in pull request #9272: Fix crashes at shutdown due to references to stale debug control registry.

wkaras commented on code in PR #9272:
URL: https://github.com/apache/trafficserver/pull/9272#discussion_r1056867554


##########
src/tscore/DbgCtl.cc:
##########
@@ -84,6 +132,8 @@ DbgCtl::_get_ptr(char const *tag)
 
   auto &d{ra.data()};
 
+  ++ra.registry_reference_count;

Review Comment:
   Increment of reference count must come before line 133.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org