You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by mimaison <gi...@git.apache.org> on 2016/09/06 16:57:39 UTC

[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...

GitHub user mimaison opened a pull request:

    https://github.com/apache/kafka/pull/1827

    KAFKA-4081: Consumer API consumer new interface commitSync does not v\u2026

    \u2026erify the validity of offset
    
    Commit throws InvalidOffsetException if the offset is negative

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mimaison/kafka KAFKA-4081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1827
    
----
commit 334f82f60416c511665519362ce23d4ab22cc5fd
Author: Mickael Maison <mi...@gmail.com>
Date:   2016-09-01T16:41:16Z

    KAFKA-4081: Consumer API consumer new interface commitSync does not verify the validity of offset
    
    Commit throws InvalidOffsetException if the offset is negative

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1827


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...

Posted by mimaison <gi...@git.apache.org>.
Github user mimaison closed the pull request at:

    https://github.com/apache/kafka/pull/1827


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...

Posted by mimaison <gi...@git.apache.org>.
GitHub user mimaison reopened a pull request:

    https://github.com/apache/kafka/pull/1827

    KAFKA-4081: Consumer API consumer new interface commitSync does not v\u2026

    \u2026erify the validity of offset
    
    Commit throws InvalidOffsetException if the offset is negative

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mimaison/kafka KAFKA-4081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1827
    
----
commit 7ec08416868180422dd6df8e921c9f6027218bfa
Author: Mickael Maison <mi...@gmail.com>
Date:   2016-09-19T17:22:34Z

    KAFKA-4081: Consumer API consumer new interface commitSync does not verify the validity of offset
    
    Commit will now fail with an IllegalArgumentException when trying to commit an offset that is either negative or larger than the consumer's current position

commit e1c1674b8f661e4063e4d5bc04a86ad069a3f317
Author: Edoardo Comar <ec...@uk.ibm.com>
Date:   2016-09-21T16:14:36Z

    KAFKA-4081: Consumer API consumer new interface commitSync does not
    verify the validity of offset
    
    Commit will now fail with an IllegalArgumentException when trying to
    commit an offset that is either negative or larger than the consumer's
    current position

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---