You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/01/12 00:24:49 UTC
Review Request 65102: ATLAS-2354: Handling of empty attributes when
using select
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65102/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-2354
https://issues.apache.org/jira/browse/ATLAS-2354
Repository: atlas
Description
-------
If any select attribute is null/empty then the results won't show up
Know issue: DB select name,description
If any of the select attribute is null/empty then the gremlin query returns no result
Diffs
-----
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 75be85f11
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 76f31a34a
repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java b93e22343
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java f3afa34fd
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 295509bb5
Diff: https://reviews.apache.org/r/65102/diff/1/
Testing
-------
GremlinComposerTest and DSLQueriesTest were successful
Thanks,
Apoorv Naik
Re: Review Request 65102: ATLAS-2354: Handling of empty attributes
when using select
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65102/#review195689
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Jan. 16, 2018, 2:43 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65102/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2018, 2:43 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2354
> https://issues.apache.org/jira/browse/ATLAS-2354
>
>
> Repository: atlas
>
>
> Description
> -------
>
> If any select attribute is null/empty then the results won't show up
>
> Know issue: DB select name,description
>
> If any of the select attribute is null/empty then the gremlin query returns no result
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 9a213a32d
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 95ba46171
> repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java b7f6d3af0
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java c44eea3bb
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 5b394cb23
>
>
> Diff: https://reviews.apache.org/r/65102/diff/2/
>
>
> Testing
> -------
>
> GremlinComposerTest and DSLQueriesTest were successful
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 65102: ATLAS-2354: Handling of empty attributes
when using select
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65102/
-----------------------------------------------------------
(Updated Jan. 16, 2018, 2:43 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Rebased on latest master
Bugs: ATLAS-2354
https://issues.apache.org/jira/browse/ATLAS-2354
Repository: atlas
Description
-------
If any select attribute is null/empty then the results won't show up
Know issue: DB select name,description
If any of the select attribute is null/empty then the gremlin query returns no result
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 9a213a32d
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 95ba46171
repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java b7f6d3af0
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java c44eea3bb
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 5b394cb23
Diff: https://reviews.apache.org/r/65102/diff/2/
Changes: https://reviews.apache.org/r/65102/diff/1-2/
Testing
-------
GremlinComposerTest and DSLQueriesTest were successful
Thanks,
Apoorv Naik