You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/12 22:13:48 UTC

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6386: [WIP][HUDI-4616] Adding `PulsarSource` to `DeltaStreamer` to support ingesting from Apache Pulsar

alexeykudinkin commented on code in PR #6386:
URL: https://github.com/apache/hudi/pull/6386#discussion_r944899873


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/debezium/DebeziumSource.java:
##########
@@ -239,5 +239,13 @@ private static Dataset<Row> convertArrayColumnsToString(Dataset<Row> dataset) {
 
     return dataset;
   }
+
+  @Override
+  public void onCommit(String lastCkptStr) {

Review Comment:
   Looking at other sources realized that Debezium doesn't commit offsets currently. After confirming w/ @rmahindra123, decided to address this in that PR as it's a simple ~copy-paste~ change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org