You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CrazyHZM (GitHub)" <gi...@apache.org> on 2018/12/03 09:18:42 UTC

[GitHub] [incubator-dubbo] CrazyHZM opened pull request #2874: 2.6.x delete modifier

## What is the purpose of the change

delete unnecessary modifier

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2874 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] carryxyh commented on issue #2874: 2.6.x delete modifier

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
I think u should make your commits clean first.
This pr contains 7 commits which is not a normative act.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2874 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] CrazyHZM closed pull request #2874: 2.6.x delete modifier

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
[ pull request closed by CrazyHZM ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2874 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org