[GitHub] spark pull request #11443: [SPARK-13244][SQL] Migrates DataFrame to Dataset

[vlad17 <gi...@git.apache.org>]

Github user vlad17 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11443#discussion_r73048593
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -745,6 +825,80 @@ class DataFrame private[sql](
       }
     
       /**
    +   * Returns a new [[Dataset]] by computing the given [[Column]] expression for each element.
    +   *
    +   * {{{
    +   *   val ds = Seq(1, 2, 3).toDS()
    +   *   val newDS = ds.select(expr("value + 1").as[Int])
    +   * }}}
    +   * @since 1.6.0
    +   */
    +  def select[U1: Encoder](c1: TypedColumn[T, U1]): Dataset[U1] = {
    --- End diff --
    
    I don't think this is ever called. `select(Column*)` will always be preferred:
    
    https://gist.github.com/vlad17/93f1cb57aad42eb7de33f92d6282a44f


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org