You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Aalok Shah (JIRA)" <ji...@apache.org> on 2011/05/21 07:04:47 UTC
[jira] [Created] (THRIFT-1177) Update thrift to reflect changes in
Go's networking libraries
Update thrift to reflect changes in Go's networking libraries
-------------------------------------------------------------
Key: THRIFT-1177
URL: https://issues.apache.org/jira/browse/THRIFT-1177
Project: Thrift
Issue Type: Dependency upgrade
Components: Go - Compiler, Go - Library
Affects Versions: 0.7
Reporter: Aalok Shah
Priority: Minor
Fix For: 0.7
Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1177) Update thrift to reflect changes in
Go's networking libraries
Posted by "Trevor Summers Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trevor Summers Smith updated THRIFT-1177:
-----------------------------------------
Attachment: gopatch2-r2.diff
The first patch submitted has one bug that prevents the Cassandra thrift file from compiling (http.Get now returns three values and was returning two). I have attached the full patch with this bug fixed.
I used: 6g version release.r57.1 8294 and compiled the Cassandra-0.8.0 Thrift file successfully, and tested some of its basic functionality.
I did not do an in-depth review of all changes in this patch, because I am not yet familiar enough with the codebase.
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1177) Update thrift to reflect changes
in Go's networking libraries
Posted by "Aalok Shah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046301#comment-13046301 ]
Aalok Shah commented on THRIFT-1177:
------------------------------------
It appears in the current stable release (r57.1) of Go, http.Get() returns 3 values.
In the latest development version, http.Get() returns 2 values.
As there is no way to perform conditional compilations (a la #ifdef in C), a version can either work with the stable release or tip, but not both.
I assume the Thrift project prefers working with the latest stable release rather than the fluctuations that can occur on tip.
Thanks for looking at the patch.
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1177) Update thrift to reflect changes
in Go's networking libraries
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055668#comment-13055668 ]
Bryan Duxbury commented on THRIFT-1177:
---------------------------------------
Just to be clear, it's the first patch that should be committed, correct? That's the one that works with stable Go interpreter?
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1177) Update thrift to reflect changes
in Go's networking libraries
Posted by "Aalok Shah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064367#comment-13064367 ]
Aalok Shah commented on THRIFT-1177:
------------------------------------
The first patch (gopatch2.diff) works with the latest stable release (r58) of Go released on June 30.
The second patch (gopatch2-r2.diff) works with the previous stable release (r57) of Go.
Use the first patch.
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1177) Update thrift to reflect changes
in Go's networking libraries
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064746#comment-13064746 ]
Hudson commented on THRIFT-1177:
--------------------------------
Integrated in Thrift #191 (See [https://builds.apache.org/job/Thrift/191/])
THRIFT-1177. go: Update thrift to reflect changes in Go's networking libraries
Patch: Aalok Shah
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1146167
Files :
* /thrift/trunk/compiler/cpp/src/generate/t_go_generator.cc
* /thrift/trunk/lib/go/thrift/ttransport_test.go
* /thrift/trunk/lib/go/thrift/ttransport.go
* /thrift/trunk/lib/go/thrift/tprotocol_test.go
* /thrift/trunk/lib/go/Make.deps
* /thrift/trunk/lib/go/thrift/tsocket.go
* /thrift/trunk/lib/go/thrift/tnonblocking_socket.go
* /thrift/trunk/lib/go/thrift/thttp_client.go
* /thrift/trunk/lib/go/thrift/thttp_client_test.go
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Assignee: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1177) Update thrift to reflect changes
in Go's networking libraries
Posted by "Aalok Shah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055109#comment-13055109 ]
Aalok Shah commented on THRIFT-1177:
------------------------------------
It's been over a month since this code review was posted. Anyone interested in committing this or should I keep telling people to use my github repo instead?
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1177) Update thrift to reflect changes in
Go's networking libraries
Posted by "Aalok Shah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aalok Shah updated THRIFT-1177:
-------------------------------
Attachment: gopatch2.diff
Works with the latest version of Go as of May 16, 2011.
I don't have commit access, can someone else please confirm nothing broke and commit this? Thank You.
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1177) Update thrift to reflect changes in
Go's networking libraries
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1177.
---------------------------------
Resolution: Fixed
Assignee: Aalok Shah
I just committed this. Thanks for the patch, Aalok!
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Assignee: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1177) Update thrift to reflect changes
in Go's networking libraries
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038117#comment-13038117 ]
Bryan Duxbury commented on THRIFT-1177:
---------------------------------------
Anyone reading this feel like they can give this a review?
> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
> Key: THRIFT-1177
> URL: https://issues.apache.org/jira/browse/THRIFT-1177
> Project: Thrift
> Issue Type: Dependency upgrade
> Components: Go - Compiler, Go - Library
> Affects Versions: 0.7
> Reporter: Aalok Shah
> Priority: Minor
> Fix For: 0.7
>
> Attachments: gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira