You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/25 05:42:46 UTC

Review Request 46618: Enhanced the log message when there are duplicate volumes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
-------

Added containerId to failure message when there are duplicate volumes
in one container.


Diffs
-----

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d 

Diff: https://reviews.apache.org/r/46618/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/#review130497
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46618]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 25, 2016, 5:56 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46618/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 5:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added containerId to failure message when there are duplicate volumes
> in one container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d 
> 
> Diff: https://reviews.apache.org/r/46618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/#review130543
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On April 25, 2016, 10:56 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46618/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 10:56 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added containerId to failure message when there are duplicate volumes
> in one container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d 
> 
> Diff: https://reviews.apache.org/r/46618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/
-----------------------------------------------------------

(Updated 四月 25, 2016, 5:56 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description (updated)
-------

Added containerId to failure message when there are duplicate volumes
in one container.


Diffs
-----

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d 

Diff: https://reviews.apache.org/r/46618/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/
-----------------------------------------------------------

(Updated 四月 25, 2016, 5:56 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
-------

Added containerId to failure message when there are duplicate volumes
in one container. Also quotaed the containerId in _cleanup.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d 

Diff: https://reviews.apache.org/r/46618/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/#review130355
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46618]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 25, 2016, 5:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46618/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 5:26 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added containerId to failure message when there are duplicate volumes
> in one container. Also quotaed the containerId in _cleanup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d 
> 
> Diff: https://reviews.apache.org/r/46618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/#review130445
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 300)
<https://reviews.apache.org/r/46618/#comment194186>

    Please remove the quote.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 547)
<https://reviews.apache.org/r/46618/#comment194185>

    Quote is not needed for container id because it's generated by Mesos.


- Jie Yu


On April 25, 2016, 5:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46618/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 5:26 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added containerId to failure message when there are duplicate volumes
> in one container. Also quotaed the containerId in _cleanup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d 
> 
> Diff: https://reviews.apache.org/r/46618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/
-----------------------------------------------------------

(Updated 四月 25, 2016, 5:26 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description (updated)
-------

Added containerId to failure message when there are duplicate volumes
in one container. Also quotaed the containerId in _cleanup.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d 

Diff: https://reviews.apache.org/r/46618/diff/


Testing
-------


Thanks,

Guangya Liu