You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/21 22:57:29 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4728: Optimizations for IndexedTable resize

codecov-io commented on issue #4728: Optimizations for  IndexedTable resize
URL: https://github.com/apache/incubator-pinot/pull/4728#issuecomment-544742650
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4728?src=pr&el=h1) Report
   > Merging [#4728](https://codecov.io/gh/apache/incubator-pinot/pull/4728?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/a6f8f1e3e870aa3d242a67f92ffb28a7f6142770?src=pr&el=desc) will **increase** coverage by `7.05%`.
   > The diff coverage is `93.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4728/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4728?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4728      +/-   ##
   ============================================
   + Coverage     57.59%   64.64%   +7.05%     
     Complexity        4        4              
   ============================================
     Files          1204     1056     -148     
     Lines         64728    56293    -8435     
     Branches       9414     8346    -1068     
   ============================================
   - Hits          37281    36392     -889     
   + Misses        24610    17184    -7426     
   + Partials       2837     2717     -120
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4728?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/pinot/core/data/table/IndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0luZGV4ZWRUYWJsZS5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...che/pinot/core/data/table/IndexedTableResizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0luZGV4ZWRUYWJsZVJlc2l6ZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...ache/pinot/core/data/table/IntermediateRecord.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0ludGVybWVkaWF0ZVJlY29yZC5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [.../pinot/core/data/table/ConcurrentIndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0NvbmN1cnJlbnRJbmRleGVkVGFibGUuamF2YQ==) | `96.61% <100%> (+1.05%)` | `0 <0> (ø)` | :arrow_down: |
   | [...not/core/data/table/RandomIndexedTableResizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JhbmRvbUluZGV4ZWRUYWJsZVJlc2l6ZXIuamF2YQ==) | `69.23% <69.23%> (ø)` | `0 <0> (?)` | |
   | [...ache/pinot/core/data/table/SimpleIndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1NpbXBsZUluZGV4ZWRUYWJsZS5qYXZh) | `91.83% <89.65%> (-4.72%)` | `0 <0> (ø)` | |
   | [...ot/core/data/table/OrderedIndexedTableResizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL09yZGVyZWRJbmRleGVkVGFibGVSZXNpemVyLmphdmE=) | `97.02% <97.02%> (ø)` | `0 <0> (?)` | |
   | [...org/apache/pinot/core/data/order/OrderByUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL29yZGVyL09yZGVyQnlVdGlscy5qYXZh) | `0% <0%> (-64.82%)` | `0% <0%> (ø)` | |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `52.68% <0%> (-15.06%)` | `0% <0%> (ø)` | |
   | ... and [190 more](https://codecov.io/gh/apache/incubator-pinot/pull/4728/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4728?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4728?src=pr&el=footer). Last update [a6f8f1e...5729f32](https://codecov.io/gh/apache/incubator-pinot/pull/4728?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org