You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/06 02:47:45 UTC
[GitHub] [incubator-echarts] BrianGilbert opened a new pull request #12387:
[#12386] Added series.typeNames values values to english lang.
BrianGilbert opened a new pull request #12387: [#12386] Added series.typeNames values values to english lang.
URL: https://github.com/apache/incubator-echarts/pull/12387
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Adds missing series.typeNames values to english translation
### Fixed issues
- #12386
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
Translations for series.typeNames were missing.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
Translations added
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] BrianGilbert commented on issue #12387:
[#12386] Added series.typeNames values values to english lang.
Posted by GitBox <gi...@apache.org>.
BrianGilbert commented on issue #12387: [#12386] Added series.typeNames values values to english lang.
URL: https://github.com/apache/incubator-echarts/pull/12387#issuecomment-609541311
@susiwen8 ah, thanks, I've updated the PR without them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12387: [#12386]
Added series.typeNames values values to english lang.
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12387: [#12386] Added series.typeNames values values to english lang.
URL: https://github.com/apache/incubator-echarts/pull/12387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12387:
[#12386] Added series.typeNames values values to english lang.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12387: [#12386] Added series.typeNames values values to english lang.
URL: https://github.com/apache/incubator-echarts/pull/12387#issuecomment-609538451
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on issue #12387: [#12386]
Added series.typeNames values values to english lang.
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #12387: [#12386] Added series.typeNames values values to english lang.
URL: https://github.com/apache/incubator-echarts/pull/12387#issuecomment-609539921
@BrianGilbert Thanks, but you don't have to add dist/ files to this commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12387:
[#12386] Added series.typeNames values values to english lang.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12387: [#12386] Added series.typeNames values values to english lang.
URL: https://github.com/apache/incubator-echarts/pull/12387#issuecomment-610411185
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org