You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/06/28 17:49:01 UTC
[GitHub] [avro] RyanSkraba opened a new pull request, #1741: AVRO-3553: Limit changes to rubocop lint
RyanSkraba opened a new pull request, #1741:
URL: https://github.com/apache/avro/pull/1741
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses AVRO-3553
### Tests
- [X] My PR does not need testing for this extremely good reason: fixing a build failure.
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1741: AVRO-3553: Limit changes to rubocop lint
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged PR #1741:
URL: https://github.com/apache/avro/pull/1741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1741: AVRO-3553: Limit changes to rubocop lint
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #1741:
URL: https://github.com/apache/avro/pull/1741#issuecomment-1169955419
Thanks @tjwp! Is there any value to adding the `Gemspec/DeprecatedAttributeAssignment` rule?
I'm still going to have to learn a bit more ruby one day :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1741: AVRO-3553: Limit changes to rubocop lint
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #1741:
URL: https://github.com/apache/avro/pull/1741#issuecomment-1169747321
I'm going to merge this as-is to unblock the build!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] tjwp commented on pull request #1741: AVRO-3553: Limit changes to rubocop lint
Posted by GitBox <gi...@apache.org>.
tjwp commented on PR #1741:
URL: https://github.com/apache/avro/pull/1741#issuecomment-1169830917
Sorry I didn't see this earlier. I think this other fix would have been to remove these lines from `.rubocop.yml`: https://github.com/apache/avro/blob/master/lang/ruby/.rubocop.yml#L54-L55
I can file an issue to remove the version restriction on the main branch. This is okay for the 1.11.1 release as it affects development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org