You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/05/21 16:08:06 UTC

[GitHub] [incubator-mxnet] szha commented on a change in pull request #20288: [v1.x] [CD] Add Aarch64 to cd

szha commented on a change in pull request #20288:
URL: https://github.com/apache/incubator-mxnet/pull/20288#discussion_r637040075



##########
File path: tools/pip/setup.py
##########
@@ -127,7 +127,7 @@
 package_name = 'mxnet'
 
 variant = os.environ['mxnet_variant'].upper()
-if variant != 'CPU':
+if not variant.endswith('CPU'):
     package_name = 'mxnet_{0}'.format(variant.lower())

Review comment:
       I don't think arm would require a new package name. package name `mxnet` with a proper platform tag for arm would suffice.
   
   What's the output of `python3 -m pip debug --verbose`? We can choose a general enough one from this and use it as platform tag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org