You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2013/06/06 03:36:00 UTC

Re: Review Request: SHINDIG-1916: Application Data to handle Objects instead of Strings

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/#review21507
-----------------------------------------------------------

Ship it!


Committed revision 1490108

- Ryan Baxter


On May 21, 2013, 4:12 p.m., Venkat Mahadevan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11024/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 4:12 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1484816 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1484816 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1484816 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1484816 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1484816 
> 
> Diff: https://reviews.apache.org/r/11024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkat Mahadevan
> 
>