[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

[GitBox <gi...@apache.org>]

wy96f commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read
URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279232121
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
 ##########
 @@ -99,8 +91,6 @@ public Page(final SimpleString storeName,
       fileFactory = factory;
       this.storageManager = storageManager;
       this.storeName = storeName;
-      this.canBeMapped = fileFactory instanceof NIOSequentialFileFactory || fileFactory instanceof MappedSequentialFileFactory;
 
 Review comment:
   For the original version, If we use NIOSequentialFileFactory, why we use mapped file read instead? Shouldn't it be consistent with the fileFactory type?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services