You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/07/20 07:07:18 UTC
Review Request 67995: Normalized paths passed to mesos-style.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67995/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Kevin Klues.
Repository: mesos
Description
-------
This make it possible to pass in slightly messier paths to
mesos-style, e.g., paths containing double directory separators.
Diffs
-----
support/mesos-style.py 4f3488cadfe01b0969977171fb40bbc7ad840bc2
support/python3/mesos-style.py cba47c3a60ca47c9d2059574f3f6761b6361a734
Diff: https://reviews.apache.org/r/67995/diff/1/
Testing
-------
Before this patch the following invocations lint nothing
* `./support/mesos-style.py ./support/mesos-style.py`
* `./support/mesos-style.py support//mesos-style.py`
After this patch they both successfully (claim to) lint the file.
Thanks,
Benjamin Bannier
Re: Review Request 67995: Normalized paths passed to mesos-style.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67995/#review206261
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On juil. 20, 2018, 7:07 matin, Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67995/
> -----------------------------------------------------------
>
> (Updated juil. 20, 2018, 7:07 matin)
>
>
> Review request for mesos, Armand Grillet and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This make it possible to pass in slightly messier paths to
> mesos-style, e.g., paths containing double directory separators.
>
>
> Diffs
> -----
>
> support/mesos-style.py 4f3488cadfe01b0969977171fb40bbc7ad840bc2
> support/python3/mesos-style.py cba47c3a60ca47c9d2059574f3f6761b6361a734
>
>
> Diff: https://reviews.apache.org/r/67995/diff/1/
>
>
> Testing
> -------
>
> Before this patch the following invocations lint nothing
>
> * `./support/mesos-style.py ./support/mesos-style.py`
> * `./support/mesos-style.py support//mesos-style.py`
>
> After this patch they both successfully (claim to) lint the file.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67995: Normalized paths passed to mesos-style.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67995/#review206269
-----------------------------------------------------------
PASS: Mesos patch 67995 was successfully built and tested.
Reviews applied: `['67995']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1961/mesos-review-67995
- Mesos Reviewbot Windows
On July 20, 2018, 7:07 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67995/
> -----------------------------------------------------------
>
> (Updated July 20, 2018, 7:07 a.m.)
>
>
> Review request for mesos, Armand Grillet and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This make it possible to pass in slightly messier paths to
> mesos-style, e.g., paths containing double directory separators.
>
>
> Diffs
> -----
>
> support/mesos-style.py 4f3488cadfe01b0969977171fb40bbc7ad840bc2
> support/python3/mesos-style.py cba47c3a60ca47c9d2059574f3f6761b6361a734
>
>
> Diff: https://reviews.apache.org/r/67995/diff/1/
>
>
> Testing
> -------
>
> Before this patch the following invocations lint nothing
>
> * `./support/mesos-style.py ./support/mesos-style.py`
> * `./support/mesos-style.py support//mesos-style.py`
>
> After this patch they both successfully (claim to) lint the file.
>
>
> Thanks,
>
> Benjamin Bannier
>
>