You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Venkatesh Seetharam (JIRA)" <ji...@apache.org> on 2012/10/20 03:26:11 UTC

[jira] [Created] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Venkatesh Seetharam created SQOOP-636:
-----------------------------------------

             Summary: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
                 Key: SQOOP-636
                 URL: https://issues.apache.org/jira/browse/SQOOP-636
             Project: Sqoop
          Issue Type: Bug
    Affects Versions: 1.4.2
            Reporter: Venkatesh Seetharam
            Assignee: Venkatesh Seetharam
             Fix For: 1.4.3
         Attachments: export-test.patch

The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Venkatesh Seetharam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Venkatesh Seetharam updated SQOOP-636:
--------------------------------------

    Attachment: export-test.patch
    
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: export-test.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481124#comment-13481124 ] 

Hudson commented on SQOOP-636:
------------------------------

Integrated in Sqoop-ant-jdk-1.6-hadoop200 #251 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/251/])
    SQOOP-636: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0)

     Result = SUCCESS
jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0
Files : 
* src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java

                
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481126#comment-13481126 ] 

Hudson commented on SQOOP-636:
------------------------------

Integrated in Sqoop-ant-jdk-1.6-hadoop20 #242 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/242/])
    SQOOP-636: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0)

     Result = SUCCESS
jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0
Files : 
* src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java

                
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481128#comment-13481128 ] 

Hudson commented on SQOOP-636:
------------------------------

Integrated in Sqoop-ant-jdk-1.6-hadoop100 #233 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/233/])
    SQOOP-636: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0)

     Result = SUCCESS
jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0
Files : 
* src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java

                
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Venkatesh Seetharam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Venkatesh Seetharam updated SQOOP-636:
--------------------------------------

    Attachment:     (was: export-test.patch)
    
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481123#comment-13481123 ] 

Hudson commented on SQOOP-636:
------------------------------

Integrated in Sqoop-ant-jdk-1.6-hadoop23 #384 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/384/])
    SQOOP-636: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0)

     Result = SUCCESS
jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0
Files : 
* src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java

                
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Venkatesh Seetharam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Venkatesh Seetharam updated SQOOP-636:
--------------------------------------

    Priority: Trivial  (was: Major)
    
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: export-test.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Venkatesh Seetharam (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481110#comment-13481110 ] 

Venkatesh Seetharam commented on SQOOP-636:
-------------------------------------------

Apologies, that was irresponsible on my part. Not sure how it happened. New patch up with the imports, compiles and tests work.
                
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481115#comment-13481115 ] 

Jarek Jarcec Cecho commented on SQOOP-636:
------------------------------------------

It's pretty small patch, so I'm giving my +1 here.
                
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Venkatesh Seetharam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Venkatesh Seetharam updated SQOOP-636:
--------------------------------------

    Attachment: SQOOP-636.patch
    
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481116#comment-13481116 ] 

Jarek Jarcec Cecho commented on SQOOP-636:
------------------------------------------

The patch has been committed: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=695666acdbef7b979d2cd64dd96d1808d7241fc0

Thank you very much for your contribution Venkatesh!

Jarcec
                
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: SQOOP-636.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SQOOP-636) ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480608#comment-13480608 ] 

Jarek Jarcec Cecho commented on SQOOP-636:
------------------------------------------

Hi Venkatesh,
thank you very much for your patch. It seems you missed import statement for classes Configuration and SqoopOptions, so that compilation of tests will fail. Would you mind adding those imports and resubmitting your patch?

Jarcec
                
> ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions 
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-636
>                 URL: https://issues.apache.org/jira/browse/SQOOP-636
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>            Priority: Trivial
>              Labels: test
>             Fix For: 1.4.3
>
>         Attachments: export-test.patch
>
>
> The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira