You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/12 07:25:52 UTC
[GitHub] [rocketmq-client-cpp] SRC-xiaojin opened a new pull request, #417: adapt to new version of boost and fix compile error
SRC-xiaojin opened a new pull request, #417:
URL: https://github.com/apache/rocketmq-client-cpp/pull/417
(cherry picked from commit 00a4d1cae74a4c01d998f651dc37c9c82e6fe1c2)
## What is the purpose of the change
adapt to new version of boost when using smart ptr
## Brief changelog
adapt to new version of boost and fix compile error
## Verifying this change
verified using boost 1.79
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ShannonDing closed pull request #417: adapt to new version of boost and fix compile error
Posted by GitBox <gi...@apache.org>.
ShannonDing closed pull request #417: adapt to new version of boost and fix compile error
URL: https://github.com/apache/rocketmq-client-cpp/pull/417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #417: adapt to new version of boost and fix compile error
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #417:
URL: https://github.com/apache/rocketmq-client-cpp/pull/417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] SRC-xiaojin commented on pull request #417: adapt to new version of boost and fix compile error
Posted by GitBox <gi...@apache.org>.
SRC-xiaojin commented on PR #417:
URL: https://github.com/apache/rocketmq-client-cpp/pull/417#issuecomment-1166513172
> Which version of boost do you use?
1.79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor commented on pull request #417: adapt to new version of boost and fix compile error
Posted by GitBox <gi...@apache.org>.
ifplusor commented on PR #417:
URL: https://github.com/apache/rocketmq-client-cpp/pull/417#issuecomment-1166747630
@SRC-xiaojin Bumping boost to 1.79 need to change build.sh, and there is another PR https://github.com/apache/rocketmq-client-cpp/pull/401 bump boost to 1.78. I am not sure which version is stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor commented on pull request #417: adapt to new version of boost and fix compile error
Posted by GitBox <gi...@apache.org>.
ifplusor commented on PR #417:
URL: https://github.com/apache/rocketmq-client-cpp/pull/417#issuecomment-1166439185
Which version of boost do you use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org