You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "eherot (via GitHub)" <gi...@apache.org> on 2023/03/20 22:15:25 UTC
[PR] [MarkerResolver] Expose parents as a list under field name `parents` (logging-log4j2)
eherot opened a new pull request, #1381:
URL: https://github.com/apache/logging-log4j2/pull/1381
PatternLayout can display the marker's parents with `%marker`. I thought it would be handy if the JSON Template Layout also had that capability.
Also added tests for the existing MarkerResolver since there weren't any
Additionally:
Slightly modified the TestHelper to catch exceptions in `readJson` and re-throw with the serialized event, to make it a little easier to debug JSON formatting issues.
## Checklist
- [x] Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise
- [x] `./mvnw verify` succeeds (if it fails due to code formatting issues reported by Spotless, simply run `spotless:apply` and retry)
- [x] Changes contain an entry file in the `src/changelog/.2.x.x` directory
- [x] Tests for the changes are provided
- [ ] [Commits are signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) (optional, but highly recommended)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MarkerResolver] Expose parents as a list under field name `parents` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #1381:
URL: https://github.com/apache/logging-log4j2/pull/1381#issuecomment-1478581281
@eherot, LGTM, merged. There are some minor changes that needs to be done. This also needs to be ported to `main`. I will take care of these. Appreciated the detailed work. :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MarkerResolver] Expose parents as a list under field name `parents` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #1381:
URL: https://github.com/apache/logging-log4j2/pull/1381#issuecomment-1477405533
Thanks so much for the contribution, @eherot! I will pick this up sometime today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MarkerResolver] Expose parents as a list under field name `parents` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #1381:
URL: https://github.com/apache/logging-log4j2/pull/1381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MarkerResolver] Expose parents as a list under field name `parents` (logging-log4j2)
Posted by "eherot (via GitHub)" <gi...@apache.org>.
eherot commented on code in PR #1381:
URL: https://github.com/apache/logging-log4j2/pull/1381#discussion_r1142731284
##########
log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/TestHelpers.java:
##########
@@ -16,6 +16,11 @@
*/
package org.apache.logging.log4j.layout.template.json;
+import java.util.LinkedHashMap;
Review Comment:
Spotless told me to make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org