You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by bo...@apache.org on 2010/01/17 12:33:09 UTC
svn commit: r900100 - in /myfaces/tobago/trunk:
core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMessages.java
theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MessagesRenderer.java
Author: bommel
Date: Sun Jan 17 11:33:08 2010
New Revision: 900100
URL: http://svn.apache.org/viewvc?rev=900100&view=rev
Log:
(TOBAGO-606) Layout-Manager
- Messages tag
Modified:
myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMessages.java
myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MessagesRenderer.java
Modified: myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMessages.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMessages.java?rev=900100&r1=900099&r2=900100&view=diff
==============================================================================
--- myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMessages.java (original)
+++ myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/component/AbstractUIMessages.java Sun Jan 17 11:33:08 2010
@@ -30,7 +30,7 @@
import java.util.List;
public abstract class AbstractUIMessages extends javax.faces.component.UIMessages
- implements LayoutComponent, OnComponentCreated {
+ implements LayoutComponent {
public List<Item> createMessageList(FacesContext facesContext) {
@@ -75,13 +75,6 @@
return messages;
}
- public void onComponentCreated(FacesContext facesContext) {
- // todo: performance
- int count = createMessageList(facesContext).size();
- // todo: is this okay? to set local values?
- setPreferredHeight(Measure.valueOf(20 * count));
- }
-
public static class Item {
private String clientId;
Modified: myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MessagesRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MessagesRenderer.java?rev=900100&r1=900099&r2=900100&view=diff
==============================================================================
--- myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MessagesRenderer.java (original)
+++ myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/MessagesRenderer.java Sun Jan 17 11:33:08 2010
@@ -231,10 +231,18 @@
}
@Override
+ public Measure getHeight(FacesContext facesContext, Configurable component) {
+ Measure measure = super.getPreferredHeight(facesContext, component);
+ UIMessages messages = (UIMessages) component;
+ int count = messages.createMessageList(facesContext).size();
+ return measure.multiply(count);
+ }
+
+ /*@Override
public Measure getPreferredHeight(FacesContext facesContext, Configurable component) {
Measure measure = super.getPreferredHeight(facesContext, component);
UIMessages messages = (UIMessages) component;
int count = messages.createMessageList(facesContext).size();
return measure.multiply(count);
- }
+ }*/
}