You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/27 04:55:42 UTC

[GitHub] [airflow] jmcarp commented on a change in pull request #5631: [AIRFLOW-5010] Add typehints for core operators

jmcarp commented on a change in pull request #5631: [AIRFLOW-5010] Add typehints for core operators
URL: https://github.com/apache/airflow/pull/5631#discussion_r307953158
 
 

 ##########
 File path: airflow/operators/bash_operator.py
 ##########
 @@ -70,10 +71,10 @@ class BashOperator(BaseOperator):
     @apply_defaults
     def __init__(
             self,
-            bash_command,
-            env=None,
-            output_encoding='utf-8',
-            *args, **kwargs):
+            bash_command: str,
+            env: Dict[str, str] = None,
 
 Review comment:
   If the default is `None`, this should be `Optional[Dict[str, str]]`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services