You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Jonathan Cook (JIRA)" <ji...@apache.org> on 2009/05/11 10:14:50 UTC
[jira] Created: (CAMEL-1599) Add the proxy options to camel-http so
you can set it easily from the URI
Add the proxy options to camel-http so you can set it easily from the URI
-------------------------------------------------------------------------
Key: CAMEL-1599
URL: https://issues.apache.org/activemq/browse/CAMEL-1599
Project: Apache Camel
Issue Type: Improvement
Components: camel-http
Affects Versions: 2.0-M1
Reporter: Jonathan Cook
Assignee: Jonathan Cook
Priority: Minor
See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1599) Add the proxy options to camel-http
so you can set it easily from the URI
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51920#action_51920 ]
Willem Jiang commented on CAMEL-1599:
-------------------------------------
Also updated the wiki page for it.
http://cwiki.apache.org/confluence/display/CAMEL/HTTP
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 1.6.2, 2.0.0
>
> Attachments: httpProxyPatch.txt
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1599) Add the proxy options to camel-http
so you can set it easily from the URI
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51874#action_51874 ]
Claus Ibsen commented on CAMEL-1599:
------------------------------------
Jonathan how goes?
I am wondering if we can make it into 2.0. Let me set the fix to 2.0 and then time will tell :)
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Jonathan Cook
> Priority: Minor
> Fix For: 2.0.0
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1599) Add the proxy options to camel-http so
you can set it easily from the URI
Posted by "Jonathan Cook (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Cook updated CAMEL-1599:
---------------------------------
Attachment: httpProxyPatch.txt
Patch attached.
I haven't included my unit test as it was testing with my companies proxy server details which obviously won't work for anyone else. I did look at public proxy servers but again worried that they suddenly could stop working.
I had a look at how the HttpClient unit tests work and they use something called a SimpleProxy.
eg)
protected SimpleProxy proxy = null;
proxy.getLocalAddress(),
proxy.getLocalPort());
I think proxy unit tests are bit tricky. I wondered if there was a way just to get at the HttpEndpoint to check the proxy details have been set but it has already tried to make the http call at that point.
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Jonathan Cook
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: httpProxyPatch.txt
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-1599) Add the proxy options to camel-http
so you can set it easily from the URI
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-1599:
-----------------------------------
Assignee: Willem Jiang (was: Jonathan Cook)
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: httpProxyPatch.txt
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1599) Add the proxy options to camel-http so
you can set it easily from the URI
Posted by "Jonathan Cook (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Cook updated CAMEL-1599:
---------------------------------
Looks good and the proxy part works for me now!
So really it is just a list of configurers which we just iterate through passing the same httpclient instance to setup the various configurations.
I haven't tested it with both basic authentication and proxy configuration.
Thanks for updating the wiki, that was on my list also :)
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 1.6.2, 2.0.0
>
> Attachments: httpProxyPatch.txt
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1599) Add the proxy options to camel-http
so you can set it easily from the URI
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51904#action_51904 ]
Willem Jiang commented on CAMEL-1599:
-------------------------------------
Hi Jonathan,
Thanks for your patch, I just went through the patch and find current solution can't handle the proxy configure and basic authentication at same time.
Maybe we can introduce a CompositeHttpClientConfigurer to handle this issue. Don't worrier I will take care of it.
Anyway, welcome to be a camel rider.
Willem
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: httpProxyPatch.txt
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-1599) Add the proxy options to camel-http
so you can set it easily from the URI
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-1599.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.6.2
Applied the patch with thanks to Jonathan.
trunk
http://svn.apache.org/viewvc?rev=778689&view=rev
camel 1.x branch
http://svn.apache.org/viewvc?rev=778748&view=rev
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 1.6.2, 2.0.0
>
> Attachments: httpProxyPatch.txt
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1599) Add the proxy options to camel-http so
you can set it easily from the URI
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-1599:
-------------------------------
Fix Version/s: 2.0.0
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Jonathan Cook
> Priority: Minor
> Fix For: 2.0.0
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1599) Add the proxy options to camel-http
so you can set it easily from the URI
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51921#action_51921 ]
Willem Jiang commented on CAMEL-1599:
-------------------------------------
@ Jonathan,
Could you check out the latest snapshot for verification ?
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 1.6.2, 2.0.0
>
> Attachments: httpProxyPatch.txt
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1599) Add the proxy options to camel-http so
you can set it easily from the URI
Posted by "Jonathan Cook (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Cook updated CAMEL-1599:
---------------------------------
Thanks. I did overlook this so apologies.
Your idea sounds a good one.
> Add the proxy options to camel-http so you can set it easily from the URI
> -------------------------------------------------------------------------
>
> Key: CAMEL-1599
> URL: https://issues.apache.org/activemq/browse/CAMEL-1599
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0-M1
> Reporter: Jonathan Cook
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: httpProxyPatch.txt
>
>
> See http://www.nabble.com/Http-Endpoint-td23430772.html#a23448297 for full history
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.