You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "lightzhao (via GitHub)" <gi...@apache.org> on 2023/03/01 10:07:48 UTC
[GitHub] [incubator-seatunnel] lightzhao opened a new pull request, #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
lightzhao opened a new pull request, #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Supplementary documents with kafkaSink
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on a diff in pull request #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on code in PR #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243#discussion_r1122649956
##########
docs/en/connector-v2/sink/Kafka.md:
##########
@@ -84,6 +84,10 @@ If name is set as the key, then the hash value of the name column will determine
If not set partition key fields, the null message key will be sent to.
+The format of the message key is json, If name is set as the key, for example '{"name":"Jack"}'.
Review Comment:
This means that after setting the "partition_key_fields" attribute, the format of the kafka message key is json, and an example is listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243#discussion_r1122657884
##########
docs/en/connector-v2/sink/Kafka.md:
##########
@@ -84,6 +84,10 @@ If name is set as the key, then the hash value of the name column will determine
If not set partition key fields, the null message key will be sent to.
+The format of the message key is json, If name is set as the key, for example '{"name":"Jack"}'.
Review Comment:
Maybe you should change to `If the format of the message is json, and the name field be setted as the partition_key_fields, for example '{"name":"Jack"}'. Then 'Jack' will be used for partition`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243#discussion_r1122643206
##########
docs/en/connector-v2/sink/Kafka.md:
##########
@@ -84,6 +84,10 @@ If name is set as the key, then the hash value of the name column will determine
If not set partition key fields, the null message key will be sent to.
+The format of the message key is json, If name is set as the key, for example '{"name":"Jack"}'.
Review Comment:
Hi, I don't get the mean about this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243#discussion_r1122658242
##########
docs/en/connector-v2/sink/Kafka.md:
##########
@@ -84,6 +84,10 @@ If name is set as the key, then the hash value of the name column will determine
If not set partition key fields, the null message key will be sent to.
+The format of the message key is json, If name is set as the key, for example '{"name":"Jack"}'.
Review Comment:
Maybe you should change to `If the format of the message is json, and the name field be setted as the partition_key_fields, for example '{"name":"Jack"}'. Then `Jack` will be used for partition`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on a diff in pull request #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on code in PR #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243#discussion_r1122665399
##########
docs/en/connector-v2/sink/Kafka.md:
##########
@@ -84,6 +84,10 @@ If name is set as the key, then the hash value of the name column will determine
If not set partition key fields, the null message key will be sent to.
+The format of the message key is json, If name is set as the key, for example '{"name":"Jack"}'.
Review Comment:
This is not the format of the message. This is the key format of the message written to kafka after setting the "partition_key_fields" attribute. For example, if the "partition_key_fields" attribute is set to name, the key of the message kafka message should be '{"name": "Jack"}'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243#discussion_r1122679149
##########
docs/en/connector-v2/sink/Kafka.md:
##########
@@ -84,6 +84,10 @@ If name is set as the key, then the hash value of the name column will determine
If not set partition key fields, the null message key will be sent to.
+The format of the message key is json, If name is set as the key, for example '{"name":"Jack"}'.
Review Comment:
I checked the code, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243#discussion_r1122657884
##########
docs/en/connector-v2/sink/Kafka.md:
##########
@@ -84,6 +84,10 @@ If name is set as the key, then the hash value of the name column will determine
If not set partition key fields, the null message key will be sent to.
+The format of the message key is json, If name is set as the key, for example '{"name":"Jack"}'.
Review Comment:
Maybe you should change to `If the format of the message is json, and the name field be setted as the partition_key_fields, for example '{"name":"Jack"}'. Then `Jack` will be used for partition`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #4243: [Doc][Connector-v2][KafkaSink]Supplementary documents
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer merged PR #4243:
URL: https://github.com/apache/incubator-seatunnel/pull/4243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org