[GitHub] [iceberg] wypoon commented on a change in pull request #3840: Spark 3.0: Fix delete from snapshot of table

[GitBox <gi...@apache.org>]

wypoon commented on a change in pull request #3840:
URL: https://github.com/apache/iceberg/pull/3840#discussion_r778344448



##########
File path: spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -244,6 +244,10 @@ private boolean requiresRewrite(Filter filter, Schema schema, Set<Integer> ident
 
   @Override
   public void deleteWhere(Filter[] filters) {
+    Preconditions.checkArgument(
+        snapshotId == null,
+        "Cannot delete from table at a specific snapshot: %s", snapshotId);
+

Review comment:
       Can you please remove this same check from `canDeleteWhere` above? That way, the check is present in only one place, the place where it is actually called.
   IIUC, Spark 3.0 doesn't actually call `SparkTable#canDeleteWhere` (Spark 3.1 does); we have `canDeleteWhere` in the code here because it was added when we had a single code base for both Spark 3.0 and 3.1.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org