You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2023/01/18 16:51:00 UTC
[jira] [Commented] (SOLR-16336) avoid fetching solrconfig.xml & schema.xml for already cached schema and config
[ https://issues.apache.org/jira/browse/SOLR-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678323#comment-17678323 ]
David Smiley commented on SOLR-16336:
-------------------------------------
I was looking at a failure from the smoke tester on my machine and I believe it's likely related this this issue based on the stack trace. Probably just a timing of resource cleanup or something; or maybe a missing "close()" in a finally maybe. Just a guess.
{noformat}
2> 440973 INFO (SUITE-TestCoreContainer-seed#[FF4893D35984B680]-worker) [] o.a.s.u.ErrorLogMuter Creating ErrorLogMuter-regex-138 for ERROR logs matching regex: ignore_exception
> java.lang.RuntimeException: file handle leaks: [InputStream(/private/tmp/smoke_solr_9.1.1_d998e63978abfedde3b75bab4ba6e1e78ddb5944/unpack/solr-9.1.1/solr/core/build/tmp/tests-tmp/solr.core.TestCoreContainer_FF4893D35984B680-001/tempDir-010/col_bad/conf/solrconfig.xml)]
> at __randomizedtesting.SeedInfo.seed([FF4893D35984B680]:0)
> at org.apache.lucene.tests.mockfile.LeakFS.onClose(LeakFS.java:63)
> at org.apache.lucene.tests.mockfile.FilterFileSystem.close(FilterFileSystem.java:69)
> at org.apache.lucene.tests.mockfile.FilterFileSystem.close(FilterFileSystem.java:70)
> at org.apache.lucene.tests.util.TestRuleTemporaryFilesCleanup.afterAlways(TestRuleTemporaryFilesCleanup.java:223)
> at com.carrotsearch.randomizedtesting.rules.TestRuleAdapter$1.afterAlways(TestRuleAdapter.java:31)
> at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:43)
> at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
> at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
> at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
> at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
> at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
> at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
> at java.base/java.lang.Thread.run(Thread.java:834)
>
> Caused by:
> java.lang.Exception
> at org.apache.lucene.tests.mockfile.LeakFS.onOpen(LeakFS.java:46)
> at org.apache.lucene.tests.mockfile.HandleTrackingFS.callOpenHook(HandleTrackingFS.java:82)
> at org.apache.lucene.tests.mockfile.HandleTrackingFS.newInputStream(HandleTrackingFS.java:125)
> at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.newInputStream(FilterFileSystemProvider.java:193)
> at org.apache.lucene.tests.mockfile.HandleTrackingFS.newInputStream(HandleTrackingFS.java:94)
> at java.base/java.nio.file.Files.newInputStream(Files.java:155)
> at org.apache.solr.core.SolrResourceLoader.openResource(SolrResourceLoader.java:362)
> at org.apache.solr.core.SolrConfig$ResourceProvider.<init>(SolrConfig.java:176)
> at org.apache.solr.core.SolrConfig.readXml(SolrConfig.java:397)
> at org.apache.solr.core.SolrConfig.lambda$new$1(SolrConfig.java:224)
> at org.apache.solr.schema.IndexSchemaFactory.getFromCache(IndexSchemaFactory.java:188)
> at org.apache.solr.core.SolrConfig.<init>(SolrConfig.java:217)
> at org.apache.solr.core.SolrConfig.readFromResourceLoader(SolrConfig.java:156)
> at org.apache.solr.core.ConfigSetService.createSolrConfig(ConfigSetService.java:294)
> at org.apache.solr.core.ConfigSetService.loadConfigSet(ConfigSetService.java:247)
> at org.apache.solr.core.CoreContainer.reload(CoreContainer.java:1878)
> at org.apache.solr.core.CoreContainer.reload(CoreContainer.java:1853)
> at org.apache.solr.core.TestCoreContainer.lambda$testCoreInitFailuresOnReload$12(TestCoreContainer.java:1012)
> at org.apache.lucene.tests.util.LuceneTestCase._expectThrows(LuceneTestCase.java:3002)
> at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2839)
> at org.apache.solr.core.TestCoreContainer.testCoreInitFailuresOnReload(TestCoreContainer.java:1008)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
> at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
> at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
> at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
> at com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:80)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
> at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
> at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
> at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
> at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
> at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
> at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
> at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
> at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
> at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
> at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
> at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
> at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
> at com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:80)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
> at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
> at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
> at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
> at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> ... 11 more
{noformat}
> avoid fetching solrconfig.xml & schema.xml for already cached schema and config
> -------------------------------------------------------------------------------
>
> Key: SOLR-16336
> URL: https://issues.apache.org/jira/browse/SOLR-16336
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Major
> Fix For: 9.1
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> SOLR-15337 introduced caching of schema and config as POJOs. But it still fetches the actual files from ZK. If a node has 1000's of cores a node restart ends up fetching these files as many times. we can avoid this
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org