You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Freeman Fang (JIRA)" <ji...@apache.org> on 2008/08/21 12:46:46 UTC
[jira] Created: (CXF-1760) jms transport don't support MTOM
jms transport don't support MTOM
--------------------------------
Key: CXF-1760
URL: https://issues.apache.org/jira/browse/CXF-1760
Project: CXF
Issue Type: Bug
Reporter: Freeman Fang
mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CXF-1760) jms transport don't support
MTOM
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710352#action_12710352 ]
Liu Cong edited comment on CXF-1760 at 5/18/09 5:49 AM:
--------------------------------------------------------
This is the patch for the problem above.
https://issues.apache.org/jira/secure/attachment/12408374/cxf-jms.patch
was (Author: liucong):
This is the patch for the problem above.
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.1.3
>
> Attachments: cxf-jms.patch
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CXF-1760) jms transport don't support
MTOM
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706704#action_12706704 ]
Liu Cong edited comment on CXF-1760 at 5/6/09 8:27 PM:
-------------------------------------------------------
If the config <jms:client messageType="byte"/> doesn't appear in the WSDL of the service, the JMS Transport will send MTOM message as TextMessage.
Thought the client send attachement information and the server get the attachment information, the attachment which is got by the server is not the same with the attachment information which is sent by the client.
I have compared the two messages. And I have used several kinds of attatchment for it.
1) Text File. The result is right.
2) WinRaR File. The file that is received by the server is larger than the file that is sent by the client.
3) BitMap file. The size of attachment that is sent by the client is 163166, but the size of attachment that is received is 485947, which is 167% more than the original binary data. (http://www.w3.org/TR/2008/WD-soapjms-20081121/#binding-message-body)
According to the analysis above, reason may be as follows:
1) In the client, the attachment is encoded as base64 encoding, and transfer as TextMessage in JMS.
2) The server doesn't know the encoding, and just get the text message.
So if one wants to use JMS MTOM-support, the config <jms:client messageType="byte"/> must be set, then the MTOM message will be sent as ByteMessage.
Some fixed for these should be done in CXF.
was (Author: liucong):
If the config <jms:client messageType="byte"/> doesn't appear in the WSDL of the service, the JMS Transport will send MTOM message as TextMessage.
Thought the client send attachement information and the server get the attachment information, the attachment which is got by the server is not the same with the attachment information which is sent by the client.
I have compared the two messages. And I have used several kinds of attatchment for it.
1) Text File. The result is right.
2) WinRaR File. The file that is received by the server is larger than the file that is sent by the client.
3) BitMap file. The size of attachment that is sent by the client is 163166, but the size of attachment that is received is 485947, which is 167% more than the original binary data. (http://www.w3.org/TR/2008/WD-soapjms-20081121/#binding-message-body)
According to the analysis above, reason may be as follows:
1) In the client, the attachment is encoded as base64 encoding, and transfer as TextMessage in JMS.
2) The server doesn't know the encoding, and just get the text message.
So if one wants to use JMS MTOM-support, the config <jms:client messageType="byte"/> must be set, then the MTOM message will be sent as ByteMessage.
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.1.3
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1760) jms transport don't support MTOM
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658247#action_12658247 ]
Freeman Fang commented on CXF-1760:
-----------------------------------
commit fix
http://svn.apache.org/viewvc?rev=687778&view=rev for 2.1.x branch
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.1.3, 2.2
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-1760) jms transport don't support MTOM
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Cong updated CXF-1760:
--------------------------
Attachment: cxf-jms.patch
This is the patch for the problem above.
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.1.3
>
> Attachments: cxf-jms.patch
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CXF-1760) jms transport don't support MTOM
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang reassigned CXF-1760:
---------------------------------
Assignee: Freeman Fang
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1760) jms transport don't support MTOM
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706704#action_12706704 ]
Liu Cong commented on CXF-1760:
-------------------------------
If the config <jms:client messageType="byte"/> doesn't appear in the WSDL of the service, the JMS Transport will send MTOM message as TextMessage.
Thought the client send attachement information and the server get the attachment information, the attachment which is got by the server is not the same with the attachment information which is sent by the client.
I have compared the two messages. And I have used several kinds of attatchment for it.
1) Text File. The result is right.
2) WinRaR File. The file that is received by the server is larger than the file that is sent by the client.
3) BitMap file. The size of attachment that is sent by the client is 163166, but the size of attachment that is received is 485947, which is 167% more than the original binary data. (http://www.w3.org/TR/2008/WD-soapjms-20081121/#binding-message-body)
According to the analysis above, reason may be as follows:
1) In the client, the attachment is encoded as base64 encoding, and transfer as TextMessage in JMS.
2) The server doesn't know the encoding, and just get the text message.
So if one wants to use JMS MTOM-support, the config <jms:client messageType="byte"/> must be set, then the MTOM message will be sent as ByteMessage.
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.1.3
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1760) jms transport don't support MTOM
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710672#action_12710672 ]
Freeman Fang commented on CXF-1760:
-----------------------------------
Hi LiuCong,
Besides the test failure Willem mentioned here, the patch is ok for me.
You need ensure all tests pass based on your patch, :-)
Thanks
Freeman
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.1.3
>
> Attachments: cxf-jms.patch
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1760) jms transport don't support MTOM
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710648#action_12710648 ]
Willem Jiang commented on CXF-1760:
-----------------------------------
When use the MTOM, we need to make sure the message type be binary.
In LiuCong's patch , we will check the message type in the JMSconduit send method ， where we can tell if the message has the attachments.
If the message type is text and it has the attachment messages, a configuration error will be thrown.
@Liu Cong，
Your patch addresses this issue, that is great. But you didn't change the old JMS MTOM test, so it was failed if you applied patch.
I changed the old JMS MTOM test to catch that JMS configuration exception and also updated the exception's message for it .
Please check them out.
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.1.3
>
> Attachments: cxf-jms.patch
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-1760) jms transport don't support MTOM
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved CXF-1760.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.2
2.0.9
commit fix
http://svn.apache.org/viewvc?rev=687703&view=rev for 2.0.x branch
http://svn.apache.org/viewvc?rev=687722&view=rev for trunk
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.2
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-1760) jms transport don't support MTOM
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang updated CXF-1760:
------------------------------
Fix Version/s: 2.1.3
> jms transport don't support MTOM
> --------------------------------
>
> Key: CXF-1760
> URL: https://issues.apache.org/jira/browse/CXF-1760
> Project: CXF
> Issue Type: Bug
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.0.9, 2.1.3, 2.2
>
>
> mtom can't work over jms transport because miss content-type in the protocol header, but the content-type is important for AttachmentInIntecepor to parse the attachment in the message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.