You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2024/08/23 01:32:56 UTC
[PR] Fix userdata append header restrictions [cloudstack]
nvazquez opened a new pull request, #9575:
URL: https://github.com/apache/cloudstack/pull/9575
### Description
This PR fixes the userdata header restrictions on the APPEND operation:
- Allow the second userdata not having a header
- In case the second userdata does not have a header, it uses the first userdata header as its format type
Fixes: #7918
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306655342
@nvazquez do you mean the second userdata2 should not contain #cloud-config as header?
Userdata1
```
#cloud-config
chpasswd:
list: |
root:password
expire: False
```
Userdata2
```
write_files:
- path: /root/CLOUD_INIT_WAS_HERE
```
I have tried deploying a vm with 2 userdata but it was not successfull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2307436193
<b>[SF] Trillian test result (tid-11151)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47353 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9575-t11151-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py
test_01_secure_vm_migration | `Error` | 134.38 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 134.38 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306083702
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2307007694
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2314398187
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306902938
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2314399270
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2315167091
> @kiranchavala I've added a fix for the UI encoding, by invoking `encodeURI` instead of `encodeURIComponent` for the base64 encoded userdata, this prevents encoding base64 special characters
> <img alt="Screenshot 2024-08-27 at 19 13 54" width="444" src="https://private-user-images.githubusercontent.com/5295080/361996377-bc6a4ecd-ef9b-4927-8b7b-8ef19e51f195.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ4NDE4OTcsIm5iZiI6MTcyNDg0MTU5NywicGF0aCI6Ii81Mjk1MDgwLzM2MTk5NjM3Ny1iYzZhNGVjZC1lZjliLTQ5MjctOGI3Yi04ZWYxOWU1MWYxOTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjhUMTAzOTU3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDY5YzBkOTdhZjJhYWE5YTI2ZWEzMDQ1Y2VlZGU0YTA3MjZkZDljZmY4NmYyMGQzZWY4OTU2OWViOWUzM2FmMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.hH1euWP7SCgTfVPxePoqlShdPifeJCUqLXNHeGNEFBE">
>
> (in the example, before the fix the last `==` chars were encoded as well by the encodeURIComponent function)
>
> cc @shwstppr @weizhouapache
@nvazquez I tested a main branch env. I passed the following userdata in the deploy VM form,
```
abcdefghijklmnop
```
In the DB I could see the following,
```
mysql> select * from user_vm where id=5\G;
*************************** 1. row ***************************
id: 5
iso_id: NULL
display_name: NULL
user_data: YWJjZGVmZ2hpamtsbW5vcA==
user_data_id: NULL
user_data_details: NULL
update_parameters: 1
user_vm_type: NULL
1 row in set (0.00 sec)
ERROR:
No query specified
````
So I'm not sure if it is an UI issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306900130
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2312162639
> @kiranchavala I could reproduce the issue for case 2) - it is related to the parameter sent in the UI when it is not encoded, it encodes with an extra character that makes cloud-init fail as it doesn't recognize the character:
> <img alt="Screenshot 2024-08-26 at 10 40 53" width="1336" src="https://private-user-images.githubusercontent.com/5295080/361456271-58ea2170-b346-45d7-86a6-830bdd14e821.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3NTIyNTAsIm5iZiI6MTcyNDc1MTk1MCwicGF0aCI6Ii81Mjk1MDgwLzM2MTQ1NjI3MS01OGVhMjE3MC1iMzQ2LTQ1ZDctODZhNi04MzBiZGQxNGU4MjEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjdUMDk0NTUwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjgwYTJiOWM3YTlhZDUzZjNhYjhiMDQyNmQ5YzQzY2NjZGE3MDFmN2M1MWFkMmFmMzk0MTM2MWM3ZmQ0MjgwMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.gs0Fz-9jcRYSOMoRToqSr7tCly3PK9zQtg-gISURF1U">
>
> As a workaround, I encoded the userdata first and passed it on the deploy VM manual entry
Thanks @nvazquez works fine with api call
is it possible to remove the limitation from the UI ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2310270297
@kiranchavala I could reproduce the issue for case 2) - it is related to the parameter sent in the UI when it is not encoded, it encodes with an extra character that makes cloud-init fail as it doesn't recognize the character:
<img width="1336" alt="Screenshot 2024-08-26 at 10 40 53" src="https://github.com/user-attachments/assets/58ea2170-b346-45d7-86a6-830bdd14e821">
As a workaround, I encoded the userdata first and passed it on the deploy VM manual entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2313667021
@kiranchavala I've added a fix for the UI encoding, by invoking `encodeURI` instead of `encodeURIComponent` for the base64 encoded userdata, this prevents encoding base64 special characters
<img width="427" alt="Screenshot 2024-08-27 at 19 12 17" src="https://github.com/user-attachments/assets/c7af1fdb-04fc-4cfa-913c-29662bdfd858">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2317116619
> @shwstppr can you retry with the userdata Kiran was using?
@nvazquez I tried the same userdata as well,
This is what UI sent as part of the API request,
And value stored in the DB,
```
mysql> select * from user_vm where id=7\G;
*************************** 1. row ***************************
id: 7
iso_id: NULL
display_name: NULL
user_data: d3JpdGVfZmlsZXM6Ci0gcGF0aDogL3Jvb3QvQ0xPVURfSU5JVF9XQVNfSEVSRQ==
user_data_id: NULL
user_data_details: NULL
update_parameters: 1
user_vm_type: NULL
1 row in set (0.01 sec)
```
Anyway, since the PR is tested and merged now, we can check later if there comes any issue in the future (less likely)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306014977
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306084892
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306902412
@kiranchavala thanks for testing, that was an issue on the simple append in case the second cloudconfig userdata didn't have a header, I have fixed it, Can you verify on the latest packages? Building them now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2309901683
@nvazquez @weizhouapache
Thanks for confirming
During testing found that
Test case 1 > works fine
1. Register userdata 1
```
#cloud-config
chpasswd:
list: |
root:password
expire: False
```
2. Register userdata 2
```
write_files:
- path: /root/CLOUD_INIT_WAS_HERE
```
attach userdata 1 to template with append
Deploy vm with advance settings userdata 2
---
Test case 2 : The user data doesn't append if we deploy the vm with manual userdata
---
Test case 3 : Works fine if the manual userdata contains the header #cloud-config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2314495948
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2315492650
@shwstppr can you retry with the userdata Kiran was using?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306013336
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306018683
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9575?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.30%. Comparing base [(`1a403f1`)](https://app.codecov.io/gh/apache/cloudstack/commit/1a403f1a9d23395b413ff2adb2e5307dccb9773b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0e723f4`)](https://app.codecov.io/gh/apache/cloudstack/commit/0e723f43a424407ce4d522858c16c06ba98913a7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (1a403f1) and HEAD (0e723f4). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (1a403f1) | HEAD (0e723f4) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #9575 +/- ##
============================================
- Coverage 15.08% 4.30% -10.79%
============================================
Files 5406 366 -5040
Lines 472915 29514 -443401
Branches 58400 5162 -53238
============================================
- Hits 71336 1270 -70066
+ Misses 393637 28100 -365537
+ Partials 7942 144 -7798
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9575/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9575?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306066195
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix userdata append header restrictions [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9575:
URL: https://github.com/apache/cloudstack/pull/9575#issuecomment-2306679252
> @nvazquez do you mean the second userdata2 should not contain #cloud-config as header?
>
> Userdata1
>
> ```
> #cloud-config
> chpasswd:
> list: |
> root:password
> expire: False
> ```
>
> Userdata2
>
> ```
> write_files:
> - path: /root/CLOUD_INIT_WAS_HERE
> ```
>
> I have tried deploying a vm with 2 userdata but it was not successfull
@kiranchavala
I think the idea is
- userdata1 must have a header
- userdata2 header is optional. If userdata2 does not have a header, it will be considered to have the same header as userdata1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org