You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "jmuehlner (via GitHub)" <gi...@apache.org> on 2023/06/21 19:10:55 UTC
[GitHub] [guacamole-client] jmuehlner opened a new pull request, #893: GUACAMOLE-1796: Batch updates to permissions so connection import won't fail if many connections are granted to a user.
jmuehlner opened a new pull request, #893:
URL: https://github.com/apache/guacamole-client/pull/893
The issue here is that if you do a connection batch import with a file with 1000 connections, granting permission to each of these connections to a single user:
1. The connection creation succeeds since the connection creation is properly batched
2. The attempt to grant permissions causes an error since the permission updates were _not_ batched
This PR fixes #2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #893: GUACAMOLE-1796: Batch updates to permissions so connection import won't fail if many connections are granted to a user.
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on PR #893:
URL: https://github.com/apache/guacamole-client/pull/893#issuecomment-1601630522
If specific to batch import, then this should be [GUACAMOLE-926](https://issues.apache.org/jira/browse/GUACAMOLE-926). If not, then GUACAMOLE-1796 is correct, but:
* This should target `staging/1.5.3` as a bug fix.
* The fix shouldn't be specific to batch import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on pull request #893: GUACAMOLE-1796: Batch updates to permissions so large permission changes can succeed.
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #893:
URL: https://github.com/apache/guacamole-client/pull/893#issuecomment-1601753241
Good call, this isn't batch specific. I've rebased against 1.5.3 and gotten rid of connection-import-specific language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #893: GUACAMOLE-1796: Batch updates to permissions so connection import won't fail if many connections are granted to a user.
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on PR #893:
URL: https://github.com/apache/guacamole-client/pull/893#issuecomment-1601627748
Is the issue specific to batch import? I'd think the same issue would arise if someone attempts to grant permissions to a bunch of connections at once, either via the REST API or through quite a lot of box-checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper merged pull request #893: GUACAMOLE-1796: Batch updates to permissions so large permission changes can succeed.
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper merged PR #893:
URL: https://github.com/apache/guacamole-client/pull/893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org