You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/28 17:25:27 UTC
[GitHub] [incubator-druid] jihoonson opened a new pull request #7368:
maxTotalRows should be checked in DataSourceCompactionConfig before setting
targetCompactionSizeBytes
jihoonson opened a new pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes
URL: https://github.com/apache/incubator-druid/pull/7368
Fixes https://github.com/apache/incubator-druid/issues/7356.
In auto compaction, `maxTotalRows` and `maxRowsPerSegment` are not supposed to set if `targetCompactionSizeBytes` is set. But, if `targetCompactionSizeBytes` and `maxTotalRows` are set to null, both are set to some default values which makes submitting compaction tasks failed. In this PR, I fixed this bug and added integration tests for auto compaction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org