[GitHub] [incubator-dubbo] biyuhao opened pull request #3327: Fix random ut falling in DubboMonitorTest

["biyuhao (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

Fix random ut falling in DubboMonitorTest
Fix wrong parameter order of `assertEquals("expected", "actual")`

## Brief changelog

`DubboMonitor#send()` may not executed after ` monitor.collect(statistics);`
Then subsequent assertion may fail.
So manual trigger `send()` after `collect()` in `DubboMonitorTest#testCount()`.

## Verifying this change

UT should always pass on jdk11

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3327 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 closed pull request #3327: Fix random ut falling in DubboMonitorTest

["ralf0131 (GitHub)" <gi...@apache.org>]

[ pull request closed by ralf0131 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3327 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3327: Fix random ut falling in DubboMonitorTest

["ralf0131 (GitHub)" <gi...@apache.org>]

Hi, would you please also confirm whether a pull request is needed for 2.6.x branch?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3327 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3327: Fix random ut falling in DubboMonitorTest

["CrazyHZM (GitHub)" <gi...@apache.org>]

LGTM

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3327 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3327: Fix random ut falling in DubboMonitorTest

["CrazyHZM (GitHub)" <gi...@apache.org>]

What is the role of swapping positions here?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3327 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] biyuhao commented on pull request #3327: Fix random ut falling in DubboMonitorTest

["biyuhao (GitHub)" <gi...@apache.org>]

Expected value should be the first parameter of `asertEquals`.
for example, this is current error message which `expected` value and `actual` value was swapped:
```
[ERROR] testCount  Time elapsed: 0.075 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.apache.dubbo.monitor.dubbo.DubboMonitorTest.testCount(DubboMonitorTest.java:116)
```
it should be:
"expected: <1> but was: <0>"

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3327 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org