You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/25 21:25:00 UTC

[jira] [Work logged] (GOBBLIN-1525) Fix bug where FlowConfigV2ResourceHandler is being casted to FlowConfigResourceHandler

     [ https://issues.apache.org/jira/browse/GOBBLIN-1525?focusedWorklogId=641989&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641989 ]

ASF GitHub Bot logged work on GOBBLIN-1525:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Aug/21 21:24
            Start Date: 25/Aug/21 21:24
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request #3376:
URL: https://github.com/apache/gobblin/pull/3376


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1525
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
       
       ControllerUserDefinedMessageHandlerFactory is casting FlowConfigV2ResourceLocalHandler to FlowConfigResourceLocalHandler, causing class cast exceptions when fetching the responses as they are not backwards compatible. 
       
       This PR fixes this issue by explicitly setting the class variable to be the newer and supported version of the resource handler.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 641989)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix bug where FlowConfigV2ResourceHandler is being casted to FlowConfigResourceHandler
> --------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1525
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1525
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Continuation from this PR https://github.com/apache/gobblin/pull/3373
> The FlowConfigV2ResourceHandler is being casted to FlowConfigResourceHandler, which still leads to a classcastexception when fetching the response as they are not backwards compatible. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)