You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/08/18 14:49:59 UTC
Review Request 37574: RANGER-616 : Add UI validation for max length of
service conf properties fields
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37574/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-616
https://issues.apache.org/jira/browse/RANGER-616
Repository: ranger
Description
-------
Add a validation of the user input and prevent entering invalid (i.e. longer) values for repo config properties.
Currently if user adds value more than the specified input, the service creation fails. We need to warn user before trying to create service.
Diffs
-----
security-admin/src/main/webapp/scripts/models/RangerServiceDef.js f76938db35e35487e68c3c19df64bf05c5a7396e
Diff: https://reviews.apache.org/r/37574/diff/
Testing
-------
Tested on a local Ranger setup for proper validation message for max length.
Thanks,
Gautam Borad
Re: Review Request 37574: RANGER-616 : Add UI validation for max
length of service conf properties fields
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37574/#review95787
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 18, 2015, 12:49 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37574/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 12:49 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-616
> https://issues.apache.org/jira/browse/RANGER-616
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Add a validation of the user input and prevent entering invalid (i.e. longer) values for repo config properties.
>
> Currently if user adds value more than the specified input, the service creation fails. We need to warn user before trying to create service.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/models/RangerServiceDef.js f76938db35e35487e68c3c19df64bf05c5a7396e
>
> Diff: https://reviews.apache.org/r/37574/diff/
>
>
> Testing
> -------
>
> Tested on a local Ranger setup for proper validation message for max length.
>
>
> Thanks,
>
> Gautam Borad
>
>