You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2013/01/16 23:55:33 UTC

Review Request: FLUME-1852: Issues with EmbeddedAgentConfiguration

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8975/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Fixes issues mentioned in 1852.


This addresses bug FLUME-1852.
    https://issues.apache.org/jira/browse/FLUME-1852


Diffs
-----

  flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java e52f912 
  flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java 0a53c5f 
  flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java 3805ea8 
  flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java 4e94d72 

Diff: https://reviews.apache.org/r/8975/diff/


Testing
-------

Unit tests pass and adds tests for items which can be tested.


Thanks,

Brock Noland

Re: Review Request: FLUME-1852: Issues with EmbeddedAgentConfiguration

Posted by Mike Percy <mp...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8975/#review15665
-----------------------------------------------------------

Ship it!


Ship It!

- Mike Percy


On Jan. 16, 2013, 10:55 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8975/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 10:55 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Fixes issues mentioned in 1852.
> 
> 
> This addresses bug FLUME-1852.
>     https://issues.apache.org/jira/browse/FLUME-1852
> 
> 
> Diffs
> -----
> 
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java e52f912 
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java 0a53c5f 
>   flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java 3805ea8 
>   flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java 4e94d72 
> 
> Diff: https://reviews.apache.org/r/8975/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass and adds tests for items which can be tested.
> 
> 
> Thanks,
> 
> Brock Noland
> 
>