You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/07/31 00:46:50 UTC
Review Request 36959: Code safety: Remove capture by reference of a
temporary.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36959/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Repository: mesos
Description
-------
For more detail on why this is bad, see MESOS-2629.
Diffs
-----
src/master/registrar.hpp 6bc78c4904effde8e4108cf226467419dd014e2f
Diff: https://reviews.apache.org/r/36959/diff/
Testing
-------
`make check`
Thanks,
Joseph Wu
Re: Review Request 36959: Code safety: Remove capture by reference of
a temporary.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36959/#review93663
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On July 30, 2015, 10:46 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36959/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 10:46 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For more detail on why this is bad, see MESOS-2629.
>
>
> Diffs
> -----
>
> src/master/registrar.hpp 6bc78c4904effde8e4108cf226467419dd014e2f
>
> Diff: https://reviews.apache.org/r/36959/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>