[GitHub] [skywalking] wu-sheng commented on a change in pull request #2710: Remove the ex which not thrown. & add logs for interceptor.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #2710: Remove the ex which not thrown. & add logs for interceptor.
URL: https://github.com/apache/skywalking/pull/2710#discussion_r285336146
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/loader/InterceptorInstanceLoader.java
 ##########
 @@ -80,6 +78,9 @@
             }
             if (inst != null) {
                 INSTANCE_CACHE.put(instanceKey, inst);
+                logger.debug("interceptor instance is created for class '{}', instanceKey is: {}", className, instanceKey);
+            }else {
 
 Review comment:
   `inst != null` is not a double-check, if `inst` can't be created by `inst = Class.forName(className, true, pluginLoader).newInstance();`, in most cases, exception should be thrown.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services