You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/07/06 20:22:20 UTC
Review Request 36214: Fix running docker executor tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.
Repository: mesos
Description
-------
When running on CentOS 7.1 it didn't have /bin in it's PATH and therefore it failed to find test-executor that is in /bin/ in the container. This works on other systems since the tests inherits the environment variables from the system and /bin usually is in the PATH.
Diffs
-----
src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055
Diff: https://reviews.apache.org/r/36214/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 36214: Fix running docker executor tests.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/#review90663
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On July 6, 2015, 1:40 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36214/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 1:40 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2996
> https://issues.apache.org/jira/browse/MESOS-2996
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When running on CentOS 7.1 it didn't have /bin in it's PATH and therefore it failed to find test-executor that is in /bin/ in the container. This works on other systems since the tests inherits the environment variables from the system and /bin usually is in the PATH.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055
>
> Diff: https://reviews.apache.org/r/36214/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 36214: Fix running docker executor tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/#review90557
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36214]
All tests passed.
- Mesos ReviewBot
On July 6, 2015, 8:40 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36214/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 8:40 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2996
> https://issues.apache.org/jira/browse/MESOS-2996
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When running on CentOS 7.1 it didn't have /bin in it's PATH and therefore it failed to find test-executor that is in /bin/ in the container. This works on other systems since the tests inherits the environment variables from the system and /bin usually is in the PATH.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055
>
> Diff: https://reviews.apache.org/r/36214/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 36214: Fix running docker executor tests.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/#review90665
-----------------------------------------------------------
Ship it!
- Joerg Schad
On July 6, 2015, 8:40 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36214/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 8:40 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2996
> https://issues.apache.org/jira/browse/MESOS-2996
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When running on CentOS 7.1 it didn't have /bin in it's PATH and therefore it failed to find test-executor that is in /bin/ in the container. This works on other systems since the tests inherits the environment variables from the system and /bin usually is in the PATH.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055
>
> Diff: https://reviews.apache.org/r/36214/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 36214: Fix running docker executor tests.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/
-----------------------------------------------------------
(Updated July 6, 2015, 8:40 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.
Bugs: MESOS-2996
https://issues.apache.org/jira/browse/MESOS-2996
Repository: mesos
Description
-------
When running on CentOS 7.1 it didn't have /bin in it's PATH and therefore it failed to find test-executor that is in /bin/ in the container. This works on other systems since the tests inherits the environment variables from the system and /bin usually is in the PATH.
Diffs
-----
src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055
Diff: https://reviews.apache.org/r/36214/diff/
Testing
-------
make check
Thanks,
Timothy Chen