You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Daniel Halperin (JIRA)" <ji...@apache.org> on 2016/12/01 22:39:58 UTC
[jira] [Updated] (BEAM-1073) Staged websites have extra whitespace
around links
[ https://issues.apache.org/jira/browse/BEAM-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Halperin updated BEAM-1073:
----------------------------------
Description:
cc [~davor] [~frances]
e.g., http://apache-beam-website-pull-requests.storage.googleapis.com/97/documentation/runners/flink/index.html
has this source when staged:
{code}
<li>
<a href="/97/documentation/programming-guide/index.html">
Programming Guide
</a>
</li>
{code}
but this source:
{code}
<li><a href="/documentation/programming-guide/">Programming Guide</a></li>
{code}
when live. I assume this comes from the rewriting tool we use to make directories work.
The former (space between end of {{Guide}} and {{</a>}}) is what I assume causes the visual effects.
NBD, but I spent a while figuring out why someone's PR caused this to happen and then saw it disappear after merging and going live.
was:
cc [~davor] [~frances]
e.g., http://apache-beam-website-pull-requests.storage.googleapis.com/97/documentation/runners/flink/index.html
has this source when staged:
{code}
<li>
<a href="/97/documentation/programming-guide/index.html">
Programming Guide
</a>
</li>
{code}
but this source:
{code}
<li><a href="/documentation/programming-guide/">Programming Guide</a></li>
{code}
when live. I assume this comes from the rewriting tool we use to make directories work.
NBD, but I spent a while figuring out why someone's PR caused this to happen and then saw it disappear after merging and going live.
> Staged websites have extra whitespace around links
> --------------------------------------------------
>
> Key: BEAM-1073
> URL: https://issues.apache.org/jira/browse/BEAM-1073
> Project: Beam
> Issue Type: Bug
> Components: website
> Affects Versions: Not applicable
> Reporter: Daniel Halperin
> Assignee: Jason Kuster
> Priority: Minor
> Fix For: Not applicable
>
>
> cc [~davor] [~frances]
> e.g., http://apache-beam-website-pull-requests.storage.googleapis.com/97/documentation/runners/flink/index.html
> has this source when staged:
> {code}
> <li>
> <a href="/97/documentation/programming-guide/index.html">
> Programming Guide
> </a>
> </li>
> {code}
> but this source:
> {code}
> <li><a href="/documentation/programming-guide/">Programming Guide</a></li>
> {code}
> when live. I assume this comes from the rewriting tool we use to make directories work.
> The former (space between end of {{Guide}} and {{</a>}}) is what I assume causes the visual effects.
> NBD, but I spent a while figuring out why someone's PR caused this to happen and then saw it disappear after merging and going live.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)