[GitHub] [orc] guiyanakuang commented on a change in pull request #943: ORC-1034: Fix the indexOf algorithm in FileDump.java

[GitBox <gi...@apache.org>]

guiyanakuang commented on a change in pull request #943:
URL: https://github.com/apache/orc/pull/943#discussion_r733268269



##########
File path: java/tools/src/test/org/apache/orc/tools/TestFileDump.java
##########
@@ -703,4 +703,12 @@ public void testHasNull() throws Exception {
     assumeTrue(!System.getProperty("os.name").startsWith("Windows"));
     TestFileDump.checkOutput(outputFilename, workDir + File.separator + outputFilename);
   }
+
+  @Test
+  public void testIndexOf() {
+    byte[] bytes = ("OO" + OrcFile.MAGIC).getBytes(StandardCharsets.UTF_8);
+    byte[] pattern = OrcFile.MAGIC.getBytes(StandardCharsets.UTF_8);
+
+    assertEquals(FileDump.indexOf(bytes, pattern, 1), 2);

Review comment:
       You're right, I didn't realize for a long time that the order of the arguments would affect the prompt message




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org