You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Emond Papegaaij (Jira)" <ji...@apache.org> on 2022/04/11 08:42:00 UTC

[jira] [Resolved] (WICKET-6970) Unnecessary string building in AssociatedMarkupSourcingStrategy

     [ https://issues.apache.org/jira/browse/WICKET-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emond Papegaaij resolved WICKET-6970.
-------------------------------------
    Fix Version/s: 10.0.0
                   9.10.0
       Resolution: Fixed

> Unnecessary string building in AssociatedMarkupSourcingStrategy
> ---------------------------------------------------------------
>
>                 Key: WICKET-6970
>                 URL: https://issues.apache.org/jira/browse/WICKET-6970
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 10.0.0, 9.9.0
>            Reporter: Emond Papegaaij
>            Assignee: Emond Papegaaij
>            Priority: Major
>             Fix For: 10.0.0, 9.10.0
>
>
> {{AssociatedMarkupSourcingStrategy.renderAssociatedMarkup}} builds a string just for an exception message. The method {{MarkupContainer.renderAssociatedMarkup}} is only called from this single location and is not really meant for public consumption. I suggest we inline the message and only build it when it's actually needed. For 9.x we must keep the parameter, but we can call it with {{null.}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)