You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/07/13 02:20:25 UTC

[GitHub] [hbase] Apache9 commented on a diff in pull request #4618: HBASE-27195 Clean up netty worker/thread pool configuration

Apache9 commented on code in PR #4618:
URL: https://github.com/apache/hbase/pull/4618#discussion_r919589364


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/NettyEventLoopGroupConfig.java:
##########
@@ -37,8 +38,15 @@
 /**
  * Event loop group related config.
  */
-@InterfaceAudience.Private
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)

Review Comment:
   I think IA.LP(config) means the class name is used as a config so you should not change the class name, here we just put some config names in it, I think it could be marked as IA.Private? As changing the name does not affect end users.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org