[GitHub] bdelacretaz commented on issue #4: SLING-7932 - Use Regex to parse mvn GAVs and URLs

[GitBox <gi...@apache.org>]

bdelacretaz commented on issue #4: SLING-7932 - Use Regex to parse mvn GAVs and URLs
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/4#issuecomment-428492267
 
 
   +1 to what @bosschaert says - if the original parser works, don't fix it ;-)
   
   Note that our parent pom includes a Jacoco setup to quickly check test coverage, build with `-P jacoco-report` and see the `target/site/jacoco-merged/index.html` report. Before these changes the report indeed shows some code paths which are not tested in `ArtifactId#fromMvnUrl`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services