[GitHub] [lucene] uschindler commented on a change in pull request #480: LUCENE-10261: clean up reflection stuff in luke module and make minor adjustments

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757762651



##########
File path: lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##########
@@ -152,6 +152,14 @@ public Analyzer createAnalyzerFromClassName(String analyzerType) {
     }
   }
 
+  private Analyzer defaultAnalyzer() {
+    try {
+      return CustomAnalyzer.builder().withTokenizer("standard").build();

Review comment:
       Should the default not have Lowercase filter, too?
   I know the factory is missing in core and only available in analysis common. Maybe a better idea is to use new StandardAnalyzer() as default unless the user defines a real custom analyzer.
   
   So in short: by default use StandardAnalyzer legacy impl.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org