[GitHub] [nifi] MikeThomsen commented on a change in pull request #2861: NIFI-5248 Added new Elasticsearch json and record processors.

[GitBox <gi...@apache.org>]

MikeThomsen commented on a change in pull request #2861: NIFI-5248 Added new Elasticsearch json and record processors.
URL: https://github.com/apache/nifi/pull/2861#discussion_r345186650
 
 

 ##########
 File path: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service-api/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientService.java
 ##########
 @@ -106,16 +106,26 @@
      * @return IndexOperationResponse if successful
      * @throws IOException thrown when there is an error.
      */
-    IndexOperationResponse add(IndexOperationRequest operation) throws IOException;
+    IndexOperationResponse add(IndexOperationRequest operation);
 
     /**
-     * Index multiple documents.
+     * Bulk process multiple documents.
      *
-     * @param operations A list of documents to index.
+     * @param operations A list of index operations.
      * @return IndexOperationResponse if successful.
      * @throws IOException thrown when there is an error.
      */
-    IndexOperationResponse add(List<IndexOperationRequest> operations) throws IOException;
 
 Review comment:
   I think it's overkill. Odds are pretty low that anyone has actually written a custom processor that uses this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services