You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "bkkothari2255 (via GitHub)" <gi...@apache.org> on 2026/01/22 15:51:38 UTC

[PR] SLING-13066: [Sling Models] Migrate implpicker and basic root tests to JUnit 5 [sling-org-apache-sling-models-impl]

bkkothari2255 opened a new pull request, #73:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/73

   Issue: SLING-13066
   
   Continuing the JUnit 5 migration (following SLING-13064), covering the `implpicker` package and the first batch of the root `org.apache.sling.models.impl` package.
   
   Changes:
   * Migrated **7 test classes**:
       * `FirstImplementationPickerTest`
       * `AdapterImplementationsTest`
       * `AnnotationConflictsTest`
       * `CachingTest`
       * `ConstructorTest`
       * `ConstructorVisibilityTest`
       * `CustomInjectorTest`
   * **Note:** `AdapterFactoryTest` import changes as it was covered in SLING-13052.
   * Updated to `@ExtendWith(MockitoExtension.class)`.
   * Applied `lenient()` stubbing to preserve legacy test behavior.
   * Added missing assertion in `ConstructorTest`
   * Rearranged assertion argumentorder in `AnnotationConflictsTest`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13066: [Sling Models] Migrate implpicker and basic root tests to JUnit 5 [sling-org-apache-sling-models-impl]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #73:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/73#issuecomment-3785680057

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=73) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=73)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13066: [Sling Models] Migrate implpicker and basic root tests to JUnit 5 [sling-org-apache-sling-models-impl]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #73:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/73#issuecomment-3785208284

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=73) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=73&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=73)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-13066: [Sling Models] Migrate implpicker and basic root tests to JUnit 5 [sling-org-apache-sling-models-impl]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert merged PR #73:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/73


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org